Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps-dev): update ESLint pluggins, migrate lint rules #2625

Merged
merged 38 commits into from
Sep 5, 2024
Merged

chore(deps-dev): update ESLint pluggins, migrate lint rules #2625

merged 38 commits into from
Sep 5, 2024

Conversation

NastaLeo
Copy link
Collaborator

@NastaLeo NastaLeo commented Aug 30, 2024 •
edited
Loading

Closes: #2562

NastaLeo and others added 30 commits August 21, 2024 11:52
@NastaLeo
chore(deps): update eslint dependencies, set new config
b66d653
@NastaLeo
style(lint): set rules for eslint config
bd6f96c
@NastaLeo
chore(deps): install 'stylistic/eslint-plugin'
b77e366
@NastaLeo
style(deps): precise eslint rules, move to '@stylistic/eslint-plugin'
8d9d35a
@NastaLeo
style(deps): fix max-len rule
535481e
@NastaLeo
style(deps): add ignore caught errors rule
5fe3850
@NastaLeo
style(deps): migrate ban-types to new rules
b0ab156
@NastaLeo
style(deps): get rid of TODO check
816b7ac
@NastaLeo
style(deps): update sonarjs
24e640c
@NastaLeo
style(deps): remove unused rule
b7c6e29
@NastaLeo
style(deps): update config
fe80c5a
@NastaLeo
style(deps): turn off import.eslintrc.yml
bdf3437
@NastaLeo
style(deps): add @ts-ignore to custom plugin tests
6932cb2
@ala-n
Merge remote-tracking branch 'refs/remotes/origin/main' into tech/esl…
9d0eb2d 
…lint-rules

# Conflicts:
#	package-lock.json
#	package.json
@NastaLeo
chore(deps): replace eslint-plugin-import by eslint-plugin-import-x
afa74f0
@NastaLeo
Merge branch 'tech/esllint-rules' of https://github.com/exadel-inc/esl …
468028b 
…into tech/esllint-rules

# Conflicts:
#	package-lock.json
@NastaLeo
style(deps): update deps
c540298
@NastaLeo
style(deps): move ignore and languageOptions config to separate files
ab336e4
@NastaLeo
style(deps): split import plugin config
2be5b6f 
and global eslint config
@NastaLeo
style(deps): refactor custom rules handling
051d7cf
@NastaLeo
style(deps): fix custom rules usages
2434d44
@NastaLeo
style(deps): remove unused dependency
f7b2b70
@NastaLeo
style(deps): fix ignore files
19bd447
@ala-n
chore: refactor and rename rule config files
c4cf30e
@ala-n
chore: update dependencies to use exactly 9th version of eslint
e73afaa
@ala-n
chore: remove related .eslintignore
af766de
@ala-n
chore: temporary disable validation for subpackages
12c7f41
@NastaLeo
chore(deps): small changes of rules files structure
37b74f6
@NastaLeo
chore: fix ignore config
b0de4c5
@NastaLeo
style(deps): fix import config
dd9227d
@NastaLeo NastaLeo requested a review from a team August 30, 2024 08:53
@ala-n
Merge remote-tracking branch 'origin/main-beta' into tech/esllint-rules
e265b1b 
# Conflicts:
#	package-lock.json
#	package.json
@ala-n ala-n force-pushed the tech/esllint-rules branch from a7153ad to e265b1b Compare August 30, 2024 09:20
@ala-n ala-n added the needs review The PR is waiting for review label Aug 30, 2024
@ala-n ala-n added this to the ⚡ESL: 5.0.0 Major release milestone Aug 30, 2024
@ala-n ala-n linked an issue Aug 30, 2024 that may be closed by this pull request
[🔧 core]: migrate lint rules to ESLint Stylistic , update ESLint pluggins #2562
Open
ala-n
ala-n reviewed Aug 30, 2024
View reviewed changes
eslint/package.json
@@ -15,7 +15,7 @@
],
"scripts": {
"prepare": "npm run build",
"test": "jest",
"test": "",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary, until plugin update

@ala-n ala-n requested review from a team, yadamskaya, abarmina and fshovchko and removed request for a team August 30, 2024 13:10
dshovchko
dshovchko approved these changes Aug 30, 2024
View reviewed changes
linting/eslint.config.sonarjs.js Outdated Show resolved Hide resolved
This was referenced Sep 4, 2024
Closed
Closed
@abarmina abarmina merged commit 822da53 into main-beta Sep 5, 2024
7 checks passed
@abarmina abarmina deleted the tech/esllint-rules branch September 5, 2024 13:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
@ala-n
Copy link
Collaborator

ala-n commented Sep 19, 2024

🎉 This PR is included in version 5.0.0-beta.34 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fshovchko fshovchko fshovchko approved these changes

@abarmina abarmina abarmina approved these changes

@ala-n ala-n ala-n approved these changes

@dshovchko dshovchko dshovchko approved these changes

@yadamskaya yadamskaya Awaiting requested review from yadamskaya yadamskaya was automatically assigned from exadel-inc/esl-core-team

Assignees

@ala-n ala-n

@NastaLeo NastaLeo

Labels
dependencies Pull requests that update a dependency file needs review The PR is waiting for review released on @beta
Projects
None yet
Milestone
⚡ESL: 5.0.0 Major release
Development

Successfully merging this pull request may close these issues.

[🔧 core]: migrate lint rules to ESLint Stylistic , update ESLint pluggins
5 participants
@NastaLeo @ala-n @dshovchko @abarmina @fshovchko