feat(esl-media): observation for togglebale container state #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fshovchko
requested review from
a team,
yadamskaya,
abarmina and
NastaLeo
and removed request for
a team
ala-n
requested changes
Oct 23, 2024
ala-n
reviewed
Oct 24, 2024
fshovchko
added
blocked
fshovchko
force-pushed
the
feat/media-container-toggleable
branch
from
e8b52fd to
e66c384
Compare
|
Code Climate has analyzed commit e66c384 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 69.5% (50% is the threshold). This pull request will bring the total coverage in the repository to 65.3% (0.0% change). View more on Code Climate. |
ala-n
reviewed
Nov 21, 2024
| @@ -335,6 +346,28 @@ export class ESLMedia extends ESLBaseElement { | |||
| this.deferredReinitialize(); | |||
| } | |||
|
|
|||
| @listen({ | |||
There was a problem hiding this comment.
Regarding listeners, we have here, it's perfect if we limit them to a single actual subscription (move to service, which will probably also handle observer file functionality) (btw in addition to performance reasons, it will also simplify main file)
But initially and for that pr I'm more than fine to have them as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2712