Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🚀esl-popup]: optimize popup position calculations and rethink offsetTrigger param #2751

Open
dshovchko opened this issue Nov 6, 2024 · 1 comment
Open

[🚀esl-popup]: optimize popup position calculations and rethink offsetTrigger param #2751

dshovchko opened this issue Nov 6, 2024 · 1 comment
Assignees
@dshovchko
Labels
released on @beta waits triage Issue that waits to be reviewed and handled

Comments

@dshovchko
Copy link
Collaborator

There are two tasks for refactoring:

  • optimize calculations of popup positioning
  • rethink offsetTrigger param. Probably should be replaced with an attribute that specifies the distance between the popup and the trigger boundary
@dshovchko dshovchko added the waits triage Issue that waits to be reviewed and handled label Nov 6, 2024
@dshovchko dshovchko self-assigned this Nov 6, 2024
@dshovchko dshovchko mentioned this issue Dec 3, 2024
Merged
@ala-n
Copy link
Collaborator

ala-n commented Dec 10, 2024

🎉 This issue has been resolved in version 5.0.0-beta.42 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dshovchko dshovchko

Labels
released on @beta waits triage Issue that waits to be reviewed and handled
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dshovchko @ala-n