Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esl-media): fix conflict of alignment classes, move definition to the main mixin #2809

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

abarmina
Copy link
Collaborator

@abarmina abarmina commented Dec 6, 2024

Available classes:

  • esl-media-left
  • esl-media-right
  • esl-media-top
  • esl-media-bottom

… the main mixin

Available classes:
  - `esl-media-left`
  - `esl-media-right`
  - `esl-media-top`
  - `esl-media-bottom`

Co-authored-by: Anna Barmina <[email protected]>
@abarmina abarmina added bug Something isn't working needs review The PR is waiting for review labels Dec 6, 2024
@abarmina abarmina added this to the ⚡ESL: 5.0.0 Major release milestone Dec 6, 2024
@abarmina abarmina requested review from a team December 6, 2024 14:56
@abarmina abarmina requested review from dshovchko, yadamskaya and fshovchko and removed request for a team December 6, 2024 14:56
@ala-n ala-n merged commit 030b2d6 into main-beta Dec 9, 2024
7 checks passed
@ala-n ala-n deleted the bugfix/esl-media-alignment branch December 9, 2024 18:25
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
@ala-n
Copy link
Collaborator

ala-n commented Dec 10, 2024

🎉 This PR is included in version 5.0.0-beta.42 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs review The PR is waiting for review released on @beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants