Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esl-utils): Transition duration utility #821

Merged
merged 7 commits into from
Nov 22, 2023
Merged

Conversation

fshovchko
Copy link
Contributor

In the scope of this PR I added a utility to get a transition length

@fshovchko fshovchko requested a review from ala-n February 7, 2022 20:42
@fshovchko fshovchko self-assigned this Feb 7, 2022
@fshovchko fshovchko added the feature New feature label Feb 7, 2022
Copy link
Collaborator

@ala-n ala-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be discussed on tomorrow's call.

We should have a utility to resolve a class of problems but not specific ones. (But you are really close to making this code universal btw)
Also, the esl-utils can be extended only with unit tests provided for extending, until it's not agreed with a @exadel-inc/esl-core-team.

@ala-n
Copy link
Collaborator

ala-n commented Feb 8, 2022

To be discussed on tomorrow's call.

We should have a utility to resolve a class of problems but not specific ones. (But you are really close to making this code universal btw) Also, the esl-utils can be extended only with unit tests provided for extending, until it's not agreed with a @exadel-inc/esl-core-team.

/** @example parseTime('.5s') // 500 */
function parseTime(timeStr: string): number;

/** @example parseTimeSet('.5s, 1ms') // [500, 1] */
function parseTimeSet(timeStr: string): number[];
```

@fshovchko fshovchko requested a review from ala-n February 8, 2022 18:12
@ala-n ala-n added the require squash No action from PR author required. Marks that current PR will be merged with squash label Nov 20, 2023
@ala-n ala-n changed the base branch from main-beta to main November 20, 2023 17:04
@ala-n ala-n requested review from dshovchko and NastaLeo November 20, 2023 17:04
@ala-n ala-n added the needs review The PR is waiting for review label Nov 20, 2023
@ala-n ala-n removed the needs review The PR is waiting for review label Nov 22, 2023
Copy link

codeclimate bot commented Nov 22, 2023

Code Climate has analyzed commit 6e50bbf and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 54.7% (0.0% change).

View more on Code Climate.

@ala-n ala-n merged commit d26c96e into main Nov 22, 2023
@ala-n ala-n deleted the feat/transition-duration branch November 22, 2023 11:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
@ala-n
Copy link
Collaborator

ala-n commented Nov 24, 2023

🎉 This PR is included in version 4.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ala-n ala-n added the released label Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature released require squash No action from PR author required. Marks that current PR will be merged with squash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants