-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(esl-utils): Transition duration utility #821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be discussed on tomorrow's call.
We should have a utility to resolve a class of problems but not specific ones. (But you are really close to making this code universal btw)
Also, the esl-utils can be extended only with unit tests provided for extending, until it's not agreed with a @exadel-inc/esl-core-team.
|
…-duration # Conflicts: # src/modules/esl-utils/misc/test/format.test.ts
Code Climate has analyzed commit 6e50bbf and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 54.7% (0.0% change). View more on Code Climate. |
🎉 This PR is included in version 4.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
In the scope of this PR I added a utility to get a transition length