Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moviebytesize error when searching by hast the 1st time #219

Open
atroxix opened this issue Jul 5, 2018 · 4 comments
Open

moviebytesize error when searching by hast the 1st time #219

atroxix opened this issue Jul 5, 2018 · 4 comments

Comments

@atroxix
Copy link

atroxix commented Jul 5, 2018

With version 0.11.0 I always get this error when searching by hash the first time:

Error: code '408 Invalid parameters; moviebytesize is not number' (200)

However, when searching by name first and then searching by hash, then it works.

@raimondlume
Copy link

+1 for this, found no other information anywhere for this error.
VLSub version 0.11.0, VLC version 3.0.6

@asmolcic
Copy link

asmolcic commented Sep 2, 2019

I changed "double" to "long" in this part of the code and it works:
{ name="moviebytesize", value={
double=openSub.file.bytesize } }

@atroxix
Copy link
Author

atroxix commented Sep 2, 2019

Maybe you could create a pull request for this? 🙂

@asmolcic
Copy link

asmolcic commented Sep 2, 2019

But I shouldn't! I was actually using the version from user Timic3 whose pull request has not yet been merged. Also, I don't know lua, I just guessed what was the problem, tried it, and it worked for me. One should not contribute if he doesn't know what is he doing. :)
Maybe a better solution would be "string" instead of "long"? Also, as it seems to me, the "double" type should have never worked for anyone. Maybe it has something to do with my lua installation, or with my Linux, or maybe OpenSubtitles changed something!?
If you don't know how to implement my fix, here's some info for Linux: download the vlsub.lua file from this repository, and put it in the directory (create if doesn't exist) "/home/(user)/.local/share/vlc/lua/extensions/". Then change the line I mentioned, and restart VLC. You will probably have two VLsub plugins but you'll manage. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants