Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to REST API? #247

Open
Rainmaker52 opened this issue Jan 6, 2023 · 4 comments
Open

Migration to REST API? #247

Rainmaker52 opened this issue Jan 6, 2023 · 4 comments

Comments

@Rainmaker52
Copy link

As mentioned at https://trac.opensubtitles.org/projects/opensubtitles/wiki/DevReadFirst OpenSubtitles.org will stop offering their API in the near future:

OpenSubtitles.org API is deprecated and not possible to register new user agents anymore, we plan to turn off OpenSubtitles.org API by the end of 2023. Please use new, stable ready-to-use ​Open Subtitles REST API instead.

The REST API is documented here: https://opensubtitles.stoplight.io/docs/opensubtitles-api/e3750fd63a100-getting-started

As you might expect, it looks to be HTTPS only. I'm not sure whether http_req() in the script could be rewritten for HTTPS. I don't believe this is easy - vlc.net.* does not seem to have anything available for encryption.

Most important other changes seem to be:

  • A key only gives access to 5 downloads / day / IP
  • A user account has 10 downloads (but requires users to signup)
  • They mention a "VIP" user level, possibly indicating paid plans?

(I am already getting 401 errors. Not sure whether this is related or not, but while troubleshooting that, I came across this information. Thought it could help)

@abdulla-allaith
Copy link

Same here, 401 error on searching.
image
I guess the APIs are no longer working.

@Rainmaker52
Copy link
Author

Same here, 401 error on searching. image I guess the APIs are no longer working.

Register for an account on open subtitles, and enter the credentials in VLSub to "fix" that.

The API, as far as I can tell, is still available. But that wasn't the point of this issue.

@avipars
Copy link

avipars commented Oct 22, 2023

Look at this fork - https://github.com/mureni/vlc-opensubtitles

@q5BWr6gN
Copy link

Look at this fork - https://github.com/mureni/vlc-opensubtitles

Doesn't seem to work for me. I removed the old .lua file and installed the new one in \VLC\lua\extensions, but it doesn't show up in VLC under the old View dropdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants