Skip to content

Clean tests toml #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2020
Merged

Clean tests toml #438

merged 2 commits into from
Oct 28, 2020

Conversation

NobbZ
Copy link
Member

@NobbZ NobbZ commented Oct 27, 2020

This removes all entries in the tests.toml that refer to tests that currently are not generated at all.

The following command has been used to find and identify tests.tomls which contain any data beyond the "root" key but do not have a generator module associated:

diff \
  <(find erlang -name '*.toml' -size +18c \
     | cut -d/ -f3,3 \
     | sort) \
  <(find erlang-tests-generator -name 'tgen_*.erl' \
     | cut -d/ -f3,3 \
     | sed -e 's|^tgen_||' -e 's|\.erl$||' \
     | sort)

To actually be able to run this command, erlang and the erlang-tests-generator repository have to be cloned as siblings.

Close #437

@NobbZ NobbZ added the hacktoberfest-accepted Apply this to PRs during octoberfest that do not have an hacktoberfest issue label Oct 27, 2020
@NobbZ NobbZ requested a review from ErikSchierboom October 27, 2020 21:47
ErikSchierboom
ErikSchierboom approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be safe: removing the entries means that you'll be prompted to make a decision about those test cases if you ever run the canonical-data-syncer tool. It would also mean that if we, in the future, add tooling to detect if a track's tests.toml file needs to be updated, you would be notified.

Whether you want this is up to you. The key question here is: did you purposefully not used the canonical tests? As in, do you expect not to use the canonical tests and keep on using the current tests? If so, I would argue that setting them to false would probably be better here, as that would indicate "I know of these test cases, but we're just not using them".

@NobbZ
Copy link
Member Author

NobbZ commented Oct 28, 2020

Intend is indeed to be reminded of those on a more or less regular basis.

Problem is, that I currently do not see some other option to say, that the exercise is currently not generated.

@NobbZ NobbZ merged commit 9756b68 into exercism:master Oct 28, 2020
@NobbZ NobbZ deleted the clean-tests-toml branch October 28, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Apply this to PRs during octoberfest that do not have an hacktoberfest issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up exercises .meta/tests.toml
2 participants
@NobbZ @ErikSchierboom