Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Call external program after download #65

Open
NoDowt opened this issue Mar 22, 2024 · 7 comments
Open

[Feature] Call external program after download #65

NoDowt opened this issue Mar 22, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@NoDowt
Copy link

NoDowt commented Mar 22, 2024

Current Situation

Currently there is no option to configure any post-processing of files automatically.

Suggestion / Feature Request

Some people may find benefit to having the ability to post-process files via an external program.
An example could be to call something (e.g. musicbrainz Picard) which could update metadata with additional info not available from Tidal (e.g. genre); or transcoding the files to another format.

@NoDowt NoDowt added the enhancement New feature or request label Mar 22, 2024
@exislow
Copy link
Owner

exislow commented Mar 22, 2024

This is probably beyond the scope of this app. The idea of this is app so far is to have a simple downloader. But feel free to submit pull requests.

@exislow exislow removed their assignment Mar 22, 2024
@crankedguy
Copy link

@NoDowt : Actually I would (and do) it the other way round, embed the calls of tidal-dl-ng into another script because there I can do whatever I want with it. As exislow mentioned there might be countless cases of what people would want to call afterwards. You might be way better off this way.

@NoDowt
Copy link
Author

NoDowt commented Apr 21, 2024

@crankedguy Currently I just use the Exe/gui version, and have used other GUI front ends for different tools (not related at all to Tidal) that include a generic post-processing option that can be set to run any command line program.

Figured it might not be too hard to include here; but then I’m not familiar with Python & how easy/hard it would be to run external programs afterwards (and account for the different OS’s).

Not something that’s critical of course, and wrapping the cli version of this in a script could be the better option. If I ever find the time I might use this as a learning opportunity to figure out Python and see if I can add this in though 🤷🏼‍♂️

@crankedguy
Copy link

@NoDowt : Dude I believe in you! If you can call a python script, and can use Google, it might take you half an hour to figure that out, just google for subprocess.run, calling another program from Python is a oneliner...
without any checks on what the prog returns etc. but just the basic call that is
Python is beautiful, I grew up with Assembler and C, and I use Python almost exclusively for everything nowadays except where I cannot (because there is no environment, API for it etc) or where performance is absolute crucial/hardware access, then C it is...

@mizwdev
Copy link

mizwdev commented Apr 22, 2024

The problem is that those downloaded m4a files are not usable with DLNA to WIIM streamer, if I use FooBar it works and with their downloadable encoders I use flac.exe to convert m4a to flac without loss. So yes , a extra commandline would be appreciated where you can run your own command with parameters, thanks in advance.

@crankedguy
Copy link

crankedguy commented Apr 22, 2024

You do net need to convert anything, as the full working flac is already inside the m4a container. And as far as I saw @exislow already created the correct way to get this flac out now as an extension with a parameter setting, which is to use ffmpeg with -acodec copy

@mizwdev
Copy link

mizwdev commented Apr 23, 2024

I've the windows downloader, so how do I use it? Tried about everything and none of the downloaded files are working. I see only option to extract from MP4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants