Skip to content

Commit 43ef0cd

Browse files
authored
Merge pull request #1 from thokiller/master
[BUGFIX][PWAI-1505] added compatibility for the 404 in combination wi…
2 parents 8aa3e4d + 3b0baf6 commit 43ef0cd

File tree

2 files changed

+5
-9
lines changed
  • Plugin/Graphql/Magento/UrlRewriteGraphQl/Model/Resolver
  • etc/graphql

2 files changed

+5
-9
lines changed

Plugin/Graphql/Magento/UrlRewriteGraphQl/Model/Resolver/EntityUrl.php renamed to Plugin/Graphql/Magento/UrlRewriteGraphQl/Model/Resolver/Route.php

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
use Magento\Store\Api\Data\StoreInterface;
1111

12-
class EntityUrl
12+
class Route
1313
{
1414
/**
1515
* @var \Experius\PageNotFound\Model\PageNotFoundFactory
@@ -39,7 +39,7 @@ public function __construct(
3939
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
4040
*/
4141
public function aroundResolve(
42-
\Magento\UrlRewriteGraphQl\Model\Resolver\EntityUrl $subject,
42+
\Magento\UrlRewriteGraphQl\Model\Resolver\Route $subject,
4343
$proceed,
4444
$field,
4545
$context,
@@ -52,7 +52,7 @@ public function aroundResolve(
5252
$args['url'] = $this->savePageNotFound($args['url'], $context->getExtensionAttributes()->getStore()) ?: $args['url'];
5353
$result = $proceed($field, $context, $info, $value, $args);
5454
if (!is_null($result)) {
55-
$result['redirectCode'] = 301;
55+
$result['redirect_code'] = 301;
5656
}
5757
}
5858
return $result;
@@ -68,15 +68,12 @@ protected function savePageNotFound(
6868
$fromUrl,
6969
StoreInterface $store
7070
) {
71-
7271
/* @var $pageNotFoundModel \Experius\PageNotFound\Model\PageNotFound */
7372
$pageNotFoundModel = $this->pageNotFoundFactory->create();
74-
7573
$baseUrl = $store->getBaseUrl();
7674
if (strpos($fromUrl, $baseUrl) === false) {
7775
$fromUrl = $baseUrl . ltrim($fromUrl, '/');
7876
}
79-
8077
$pageNotFoundModel->load($fromUrl,'from_url');
8178

8279
if($pageNotFoundModel->getId()){
@@ -92,7 +89,6 @@ protected function savePageNotFound(
9289
}
9390

9491
$pageNotFoundModel->save();
95-
9692
if($pageNotFoundModel->getToUrl()) {
9793
return str_replace($baseUrl, '', $pageNotFoundModel->getToUrl());
9894
}

etc/graphql/di.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" ?>
22
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
3-
<type name="Magento\UrlRewriteGraphQl\Model\Resolver\EntityUrl">
4-
<plugin disabled="false" name="Experius_PageNotFoundGraphQl_Plugin_Graphql_Magento_UrlRewriteGraphQl_Model_Resolver_EntityUrl" sortOrder="999" type="Experius\PageNotFoundGraphQl\Plugin\Graphql\Magento\UrlRewriteGraphQl\Model\Resolver\EntityUrl"/>
3+
<type name="Magento\UrlRewriteGraphQl\Model\Resolver\Route">
4+
<plugin disabled="false" name="Experius_PageNotFoundGraphQl_Plugin_Graphql_Magento_UrlRewriteGraphQl_Model_Resolver_Route" sortOrder="999" type="Experius\PageNotFoundGraphQl\Plugin\Graphql\Magento\UrlRewriteGraphQl\Model\Resolver\Route"/>
55
</type>
66
</config>

0 commit comments

Comments
 (0)