remove flight numbers cron

explore-flights · Aug 19, 2024 · f54eecc · f54eecc
1 parent 77da261
commit f54eecc
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 157 deletions.
diff --git a/cdk/lib/constructs/api-lambda-construct.ts b/cdk/lib/constructs/api-lambda-construct.ts
@@ -84,7 +84,6 @@ export class ApiLambdaConstruct extends Construct {
     }));
 
     props.dataBucket.grantRead(lambda, 'processed/flights/*');
-    props.dataBucket.grantRead(lambda, 'processed/flight_numbers/*');
     props.dataBucket.grantRead(lambda, 'raw/ourairports_data/airports.csv');
     props.dataBucket.grantRead(lambda, 'raw/ourairports_data/countries.csv');
     props.dataBucket.grantRead(lambda, 'raw/ourairports_data/regions.csv');

diff --git a/cdk/lib/constructs/cron-lambda-construct.ts b/cdk/lib/constructs/cron-lambda-construct.ts
@@ -46,7 +46,6 @@ export class CronLambdaConstruct extends Construct {
     props.dataBucket.grantRead(this.lambda, 'raw/LH_Public_Data/flightschedules/*');
     props.dataBucket.grantWrite(this.lambda, 'raw/LH_Public_Data/*');
     props.dataBucket.grantWrite(this.lambda, 'raw/ourairports_data/*');
-    props.dataBucket.grantReadWrite(this.lambda, 'processed/flights/*');
-    props.dataBucket.grantWrite(this.lambda, 'processed/flight_numbers/*');
+    props.dataBucket.grantWrite(this.lambda, 'processed/flights/*');
   }
 }
diff --git a/cdk/lib/constructs/sfn-construct.ts b/cdk/lib/constructs/sfn-construct.ts
@@ -60,22 +60,6 @@ export class SfnConstruct extends Construct {
         resultPath: '$.convertSchedulesResponse',
         retryOnServiceExceptions: true,
       }))
-      .next(new LambdaInvoke(this, 'ConvertNumbersTask', {
-        lambdaFunction: props.cronLambda,
-        payload: TaskInput.fromObject({
-          'action': 'convert_flight_numbers',
-          'params': {
-            'inputBucket': props.dataBucket.bucketName,
-            'inputPrefix': 'processed/flights/',
-            'outputBucket': props.dataBucket.bucketName,
-            'outputPrefix': 'processed/flight_numbers/',
-            'dateRanges': JsonPath.objectAt('$.loadSchedulesResponse.loadFlightSchedules.input.dateRanges'),
-          },
-        }),
-        payloadResponseOnly: true,
-        resultPath: '$.convertNumbersResponse',
-        retryOnServiceExceptions: true,
-      }))
       .toSingleState('ConvertTry', { outputPath: '$[0]' })
       .addCatch(
         this.sendWebhookTask(

diff --git a/go/cron/action/convert_flight_numbers.go b/go/cron/action/convert_flight_numbers.go
diff --git a/go/cron/main.go b/go/cron/main.go
@@ -63,7 +63,6 @@ func newHandler(s3c *s3.Client) func(ctx context.Context, event InputEvent) (jso
 	lAircraftAction := action.NewLoadMetadataAction(s3c, lhc, (*lufthansa.Client).AircraftRaw, "aircraft")
 	lfsAction := action.NewLoadFlightSchedulesAction(s3c, lhc)
 	cfsAction := action.NewConvertFlightSchedulesAction(s3c)
-	cfnAction := action.NewConvertFlightNumbersAction(s3c)
 	cronAction := action.NewCronAction(lfsAction, cfsAction)
 	loaAction := action.NewLoadOurAirportsDataAction(s3c, nil)
 	invWHAction := action.NewInvokeWebhookAction(http.DefaultClient)
@@ -88,9 +87,6 @@ func newHandler(s3c *s3.Client) func(ctx context.Context, event InputEvent) (jso
 		case "load_flight_schedules":
 			return handle(ctx, lfsAction, event.Params)
 
-		case "convert_flight_numbers":
-			return handle(ctx, cfnAction, event.Params)
-
 		case "convert_flight_schedules":
 			return handle(ctx, cfsAction, event.Params)