Encoding option for CLI convert

[joaompfe]

Hello,

Why there's no encoding option available for CLI convert? Any special reason?

spacy/cli/convert.py has UTF-8 encoding hardcoded when opening the file.

Thanks

[joaompfe]

I have added the optional argument and changed the CLI documentation here.

Tested on my machine the option --encoding="ISO-8859-1" with success. But did not implement any test.

Should I open a pull request?

[polm]

Thanks for the offer but I don't think we need this.

spaCy only deals with utf-8 internally, just like Python 3, and I honestly can't remember the last time someone even mentioned it. While there are still reasons to work with other encodings these days, they're limited, and converting your data on the command line before giving it to spaCy isn't complicated.