chore: remove react-native-share from list of packages that do not need a config plugin #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`react-native-share` now requires (an as yet unwritten) config plugin...
EvanBacon
reviewed
Jul 27, 2022
| @@ -48,7 +48,6 @@ More out-of-tree plugins which can be used to configure more packages. | |||
|
|
|||
| Just install and rebuild! If a package doesn't require any futher setup then it most likely doesn't need an Expo config plugin. Most packages work without a config plugin (including packages not listed below): | |||
|
|
|||
| - [react-native-share](https://github.com/react-native-share/react-native-share) | |||
There was a problem hiding this comment.
Maybe just add an "iOS only, pending Android support [issue or PR]" note to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-native-sharenow requires (an as yet unwritten) config plugin...Why
How
Test Plan