Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 31b3d81

Browse files
authoredAug 13, 2024
[eas-cli] add support for EAS_DANGEROUS_OVERRIDE_IOS_BUNDLE_IDENTIFIER for bare workflow iOS builds (#2469)
* [eas-cli] add support for `EAS_DANGEROUS_OVERRIDE_IOS_BUNDLE_IDENTIFIER` for bare workflow * add changelog * fix changelog
1 parent 5cf5265 commit 31b3d81

File tree

3 files changed

+11
-0
lines changed

3 files changed

+11
-0
lines changed
 

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ This is the log of notable changes to EAS CLI and related packages.
1212

1313
### 🧹 Chores
1414

15+
- Add support for `EAS_DANGEROUS_OVERRIDE_IOS_BUNDLE_IDENTIFIER` for bare workflow iOS builds. ([#2469](https://github.com/expo/eas-cli/pull/2469) by [@szdziedzic](https://github.com/szdziedzic))
1516
- Update images list in `eas.schema.json` and warn users when using the deprecated Android images. ([#2450](https://github.com/expo/eas-cli/pull/2450) by [@szdziedzic](https://github.com/szdziedzic))
1617

1718
## [10.2.2](https://github.com/expo/eas-cli/releases/tag/v10.2.2) - 2024-07-31

‎packages/eas-cli/src/env.ts‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@ export default {
88
* ignore failures when parsing build.gradle.
99
*/
1010
overrideAndroidApplicationId: process.env.EAS_DANGEROUS_OVERRIDE_ANDROID_APPLICATION_ID,
11+
/**
12+
* Overrides bundleIdentifier from Xcode project for bare workflow.
13+
* Setting this option will ignore failures thrown when bundle identifier can't be obtained from Xcode project.
14+
*/
15+
overrideIosBundleIdentifier: process.env.EAS_DANGEROUS_OVERRIDE_IOS_BUNDLE_IDENTIFIER,
1116
/**
1217
* Comma separated list of feature gate keys of feature gates to evaluate override to true.
1318
*/

‎packages/eas-cli/src/project/ios/bundleIdentifier.ts‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import fs from 'fs-extra';
77

88
import { readAppJson } from '../../build/utils/appJson';
99
import { ExpoGraphqlClient } from '../../commandUtils/context/contextUtils/createGraphqlClient';
10+
import env from '../../env';
1011
import Log, { learnMore } from '../../log';
1112
import { promptAsync } from '../../prompts';
1213
import { Client } from '../../vcs/vcs';
@@ -62,6 +63,10 @@ export async function getBundleIdentifierAsync(
6263
if (workflow === Workflow.GENERIC) {
6364
warnIfBundleIdentifierDefinedInAppConfigForBareWorkflowProject(projectDir, exp);
6465

66+
if (env.overrideIosBundleIdentifier) {
67+
return env.overrideIosBundleIdentifier;
68+
}
69+
6570
const xcodeProject = IOSConfig.XcodeUtils.getPbxproj(projectDir);
6671
const isMultiScheme = IOSConfig.BuildScheme.getSchemesFromXcodeproj(projectDir).length > 1;
6772
const isMultiTarget =

0 commit comments

Comments
 (0)
Please sign in to comment.