Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Add buildArtifactsUrl to eas-cli build:view --json #2102

Conversation

sjchmiela
Copy link
Contributor

Why

It's nice to be able to download both application archive and "build artifact".

How

Added buildArtifactsUrl to GraphQL query. It contains the thing I'm looking for.

Test Plan

Ran easd build:view 7bab0c66-d917-4873-9241-c5fa0b01dec1 --json and confirmed it has the new field.

@linear
Copy link

linear bot commented Oct 27, 2023

ENG-10475 Add `buildArtifactsUrl` to `eas-cli build:view --json`

This way we'll be able to trigger a build and download its result.

@sjchmiela
Copy link
Contributor Author

/changelog-entry bug-fix Added buildArtifactsUrl to eas-cli build:view --json output.

@sjchmiela
Copy link
Contributor Author

/changelog-entry bug-fix Added buildArtifactsUrl to eas-cli build:view --json output.

@sjchmiela sjchmiela marked this pull request as ready for review October 27, 2023 10:13
CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions
Copy link

✅ Thank you for adding the changelog entry!

@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Size Change: +347 B (0%)

Total Size: 42.6 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 42.6 MB +347 B (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2102 (39b8a54) into main (5bf7f27) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2102   +/-   ##
=======================================
  Coverage   54.20%   54.20%           
=======================================
  Files         509      509           
  Lines       18652    18652           
  Branches     3933     3933           
=======================================
  Hits        10108    10108           
  Misses       7857     7857           
  Partials      687      687           
Files Coverage Δ
packages/eas-cli/src/graphql/generated.ts 100.00% <ø> (ø)
packages/eas-cli/src/graphql/types/Build.ts 100.00% <ø> (ø)

@sjchmiela sjchmiela merged commit dc25b20 into main Oct 27, 2023
9 checks passed
@sjchmiela sjchmiela deleted the stanley/eng-10475-add-buildartifactsurl-to-eas-cli-buildview-json branch October 27, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants