-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development Build does not work with fingerprint as Runtime Version #2511
Comments
As a temporary fix, what I have done is create app.config.js that dynamically determines the runtime version
Then in the CI/CD I set the RUNTIME_VERSION to 'fingerprint', run a script that in essence executes |
Hi @okkes In screenshot number 1, you list updates for branch production and there aren't any. It looks like you don't have any updates from branch production compatible with this runtime version, which seems correct because you don't have any updates for the production branch with this runtime version, only for branch development. Are you able to see the updates for branch development using the same version of the dev client app? It seems like there are a few compatible with this runtime version on the development branch 🤔 |
Sorry for causing confusion with that screenshot. The screenshot (1) was to actually show that the development branch was not listed. (its the screenshot made on the highest scope, that shows all the branches). The reason why the production is there is because there are no updates pushed yet. That one will also disappear as soon as I push an update there. So, the issue I am getting from this is actually related to the 4th picture. When building using fingerprint + dev client, it shows file:fingerprint as runtime version. And this one is most likely literally compared to the hash in updates. When I use the hash as custom runtime version during the build, the build can find the updates that are generated using fingerprint |
I talked about it with developers working on the dev client/fingerprint/EAS Update, and it seems like this is a bug/current limitation of the dev client that it doesn't support the fingerprint policy to load compatible updates. |
Thank you for filing this issue! |
Will fix before moving fingerprint runtime version out of beta. Should be production ready by SDK 53 or maybe 52. |
@wschurman when do you think fingerprint policy will be production ready? |
@markwitt1 - Looking like SDK 53 or 54 for continuous deployment to production (need to figure out how to do continuous submission). For development (PR comment using |
Build/Submit details page URL
https://expo.dev/accounts/jinbu/projects/my-demo-expo-app/builds/25a7434a-4535-464e-b079-4863268b939b
Summary
When creating development build using fingerprint as runtime version, the branches with the same runtime versions arent recognized as compatible update. Happens for iOS and Android apps.
Managed or bare?
managed
Environment
npx expo-env-info
npx expo-doctor
Error output
No error.
Branches that dont have any updates yet will be listed here with
no updates available
. As soon as you push an update to the branch, it disappears.In the first screenshot, you will see that the development branch is not showing. The second and third pictures shows that both the build and update runtime versions are the same.
The 4th picture shows what I see as version number, not sure if this is normal.
The 5th and 6th pictures shows that my app does work when semantic versioning is used.
1st picture
2nd picture
3rd picture
4th picture
5th picture
6th picture
Reproducible demo or steps to reproduce from a blank project
create
app.config.js
with the fingerprint runtime versionrun
eas build
commandrun
eas update
commandensure that same platform, channel, branch etc are used.
The text was updated successfully, but these errors were encountered: