[eas-cli] update expo packages to SDK 52 versions #2706
Conversation
szdziedzic
requested review from
brentvatne,
khamilowicz,
radoslawkrzemien,
sjchmiela and
wschurman
|
Subscribed to pull request
Generated by CodeMention |
There was a problem hiding this comment.
What is the codepath where this is not using the versioned config getter for SDK 52? Might be worth focusing on making all versioned packages in eas-cli unused for SDK >= 52/53 like we did for getting the app config.
Upgrading these is always risky (we hit an issue last time we tried to upgrade them IIRC)
|
Size Change: -264 kB (-0.5%) Total Size: 52.6 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2706 +/- ##
==========================================
+ Coverage 52.74% 52.75% +0.01%
==========================================
Files 580 580
Lines 22283 22272 -11
Branches 4358 4353 -5
==========================================
- Hits 11751 11747 -4
+ Misses 10496 10489 -7
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
What is the codepath where this is not using the versioned config getter for SDK 52? Might be worth focusing on making all versioned packages in eas-cli unused for SDK >= 52/53 like we did for getting the app config. Upgrading these is always risky (we hit an issue last time we tried to upgrade them IIRC)
Discussed it in DMs with @wschurman and it seems like the best option for now is to go forward with this PR as-is for now then do the decoupling for the SDK 53 release. Decoupling seems like a right long-term call allowing us to avoid many of these upgrade-related issues in the future.
There was a problem hiding this comment.
It seems like this removed privacy thing is not a breaking change because ...This field was previously used when the Expo website had optional public-facing pages for projects, which we no longer provide.
Is it true @wschurman?
|
Nice catch! This should fix it. https://app.graphite.dev/github/pr/expo/universe/17574/www-No-longer-require-obsolete-privacy-setting-in-app-creation-mutation |
| @@ -149,7 +150,7 @@ async function ensureEASUpdatesIsConfiguredInExpoConfigAsync({ | |||
| return { | |||
| projectChanged: true, | |||
| // TODO(cedric): fix return type of `modifyConfigAsync` to avoid `null` for type === success repsonses | |||
There was a problem hiding this comment.
yep, this modifyConfigAsync is probably a good thing to version next. We versioned syncUpdatesConfigurationAsync by creating a CLI for it in expo-updates.
|
Thanks! |
szdziedzic
force-pushed
the
11-19-_eas-cli_update_expo_packages_to_sdk_52_versions
branch
from
0db357b to
89aec94
Compare
|
✅ Thank you for adding the changelog entry! |
szdziedzic
deleted the
11-19-_eas-cli_update_expo_packages_to_sdk_52_versions
branch
Why
Update
@expopackages to SDK 52 versionsHow
Update
@expopackages to SDK 52 versionsFixes #2696
It seems like the
privacyfield was removed from the expo config in the SDK 52 update: https://expo.dev/changelog/2024/11-12-sdk-52.I used
AppPrivay.Unlistedfor thecreateAppmutation input for which this is still required. It was an option selected for an app whenexp.privacywas undefined.It also seems that
findWorkspaceRootfunction in@expo/package-managerwas changed toresolveWorkspaceRoot.Test Plan
Tests, test commands manually