Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testflight Group auto-creating #2858

Open
ariellemelinda opened this issue Feb 3, 2025 · 3 comments
Open

Testflight Group auto-creating #2858

ariellemelinda opened this issue Feb 3, 2025 · 3 comments
Labels
needs review Issue is ready to be reviewed by a maintainer

Comments

@ariellemelinda
Copy link

Build/Submit details page URL

No response

Summary

I'm noticing with the latest version of eas-cli (14.7.1) that a Testflight group called "Team (Expo)" is now being created as part of eas submit --platform ios and nearly everyone in my App Store connect is being added to it.

I don't want this to be occurring - anyone have any ideas as to why it is?

➜  eas submit --platform ios

✔ What would you like to submit? › Select a build from EAS
✔ Which build would you like to submit? › - ID: (redacted) (48 seconds ago)
Ensuring your app exists on App Store Connect. This step can be skipped by providing ascAppId in the submit profile. Learn more

› Log in to your Apple Developer account to continue
✔ Apple ID: … (redacted)
› Restoring session /Users/(redacted)/cookie
✔ Select a Team › (redacted)
› Provider (redacted)
✔ Logged in Local session

✔ Bundle identifier registered (redacted)
✔ Prepared App Store Connect for (redacted)
✔ TestFlight group created: Team (Expo)
TestFlight access enabled for: (redacted), (redacted), (redacted), (redacted), (redacted), (redacted), (redacted), (redacted)
Looking up credentials configuration for (redacted)...
✔ App Store Connect API Key already set up.
Using Api Key ID: (redacted) ([Expo] EAS Submit (redacted))

ASC App ID:                 (redacted)
Project ID:                 (redacted)
App Store Connect API Key:  
    Key Name  :  [Expo] EAS Submit (redacted)
    Key ID    :  (redacted)
    Key Source:  EAS servers
Build:                      
    Build ID    :  (redacted)
    Build Date  :  2/2/2025, 10:31:01 AM
    App Version :  1.0.0
    Build number:  79

✔ Scheduled iOS submission

Submission details: (redacted)

Waiting for submission to complete. You can press Ctrl+C to exit.
✔ Submitted your app to Apple App Store Connect!

Your binary has been successfully uploaded to App Store Connect!
- It is now being processed by Apple - you will receive an email when the processing finishes.
- It usually takes about 5-10 minutes depending on how busy Apple servers are.
- When it's done, you can see your build here: (redacted)
- ```


### Managed or bare?

Managed

### Environment

expo-env-info 1.2.2 environment info:
System:
OS: macOS 15.1
Shell: 5.9 - /bin/zsh
Binaries:
Node: 20.18.1 - ~/.nvm/versions/node/v20.18.1/bin/node
Yarn: 4.6.0 - ~/.nvm/versions/node/v20.18.1/bin/yarn
npm: 10.8.2 - ~/.nvm/versions/node/v20.18.1/bin/npm
Watchman: 2024.12.02.00 - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.16.2 - /Users/ariellemelinda/.rbenv/shims/pod
SDKs:
iOS SDK:
Platforms: DriverKit 24.2, iOS 18.2, macOS 15.2, tvOS 18.2, visionOS 2.2, watchOS 11.2
IDEs:
Android Studio: 2024.2 AI-242.23339.11.2421.12700392
Xcode: 16.2/16C5032a - /usr/bin/xcodebuild
npmPackages:
expo: ~51.0.22 => 51.0.39
expo-router: ~3.5.18 => 3.5.24
react: 18.2.0 => 18.2.0
react-native: 0.74.5 => 0.74.5
npmGlobalPackages:
eas-cli: 14.7.1
Expo Workflow: bare




npx expo-doctor
✔ Check package.json for common issues
✔ Check Expo config for common issues
✔ Check for common project setup issues
✔ Check dependencies for packages that should not be installed directly
✔ Check for issues with Metro config
✔ Check if the project meets version requirements for submission to app stores
✔ Check for app config fields that may not be synced in a non-CNG project
✔ Check npm/ yarn versions
✖ Check Expo config (app.json/ app.config.js) schema
✔ Check that native modules do not use incompatible support packages
✔ Check for legacy global CLI installed locally
✔ Check that native modules use compatible support package versions for installed Expo SDK
✔ Check native tooling versions
✖ Check that packages match versions required by installed Expo SDK

Detailed check results:

Error: Problem validating fields in /Users/ariellemelinda/Dev/vitb-kiosk-app/app.json. Learn more: https://docs.expo.dev/workflow/configuration/
 • should NOT have additional property 'requireFullScreen'.

The following packages should be updated for best compatibility with the installed expo version:
  [email protected] - expected version: ~13.0.3
  [email protected] - expected version: ~1.13.0
Your project may not work correctly until you install the expected versions of the packages.
Found outdated dependencies
Advice: Use 'npx expo install --check' to review and upgrade your dependencies.

One or more checks failed, indicating possible issues with the project.

### Error output

_No response_

### Reproducible demo or steps to reproduce from a blank project

Just build and submit a project to the iOS app store. 
@ariellemelinda ariellemelinda added the needs review Issue is ready to be reviewed by a maintainer label Feb 3, 2025
@EvanBacon
Copy link
Contributor

The latest version of EAS Submit generates an internal TestFlight group with the default settings and links the account admin(s). Account admins already have access to every app in the account and possess the ability to perform any action on the account, whereas all other roles require a manual invite to an individual app.

The internal group name "Team (Expo)" is meant to indicate that this particular team is "managed" and that manual modifications may be overwritten when EAS is run again.

You can have multiple internal teams, including ones with non-admins or other custom settings so this feature shouldn't be especially intrusive.

We'll add a flag to disable the new behavior but I'd advise toward reducing team member privileges if you have Apple team members that aren't supposed to access certain apps on your account. #2856

@theonetheycallneo
Copy link

It would be nice to pass custom groups via eas.json as well.

Currently we use eas to create a build then still write a custom fastlane to upload to testflight:
https://docs.fastlane.tools/actions/upload_to_testflight/

@ariellemelinda
Copy link
Author

Thanks @EvanBacon. In our case, it's not that they aren't supposed to access certain apps, but being able to access an app and being added to a testflight group, getting the notifications/emails etc are two different things. Looking forward to the flag being added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Issue is ready to be reviewed by a maintainer
Projects
None yet
Development

No branches or pull requests

3 participants