Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uploading git-ignored files to EAS #900

Closed
dsokal opened this issue Jan 10, 2022 · 14 comments
Closed

Allow uploading git-ignored files to EAS #900

dsokal opened this issue Jan 10, 2022 · 14 comments
Assignees
Labels
eas build enhancement New feature or request

Comments

@dsokal
Copy link
Contributor

dsokal commented Jan 10, 2022

It sometimes makes sense to upload git-ignored files to EAS. There should be a way to override .gitignore file rules.

See #228 (comment) for context.

@dsokal dsokal added the enhancement New feature or request label Jan 10, 2022
@DrKylstein
Copy link

For some setups, it seems you can use a negated ('!' before it) pattern in .easignore to do this. In my case I have individual files that are specifically ignored and only a single .gitignore, I don't know if this would work with ignored directories or multiple .gitignore files. Hopefully this helps somebody!

@diegoconcha
Copy link

It would be awesome if you all could add an .easincludes file instead or in addition to the .easignore file discussed here. We only want to include the aws-exports.js instead of now having to have two ignore files we need to keep up-to-date.

@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This issue is stale because it has been open for 30 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

@ShepSims
Copy link

Has anyone figured out how to get past the aws-exports and google-services.json needing to be gitignored?

adding the following to .easignore did not fix the eas:build issues for us
!aws-exports.js
!google-services.json

@VictorioMolina
Copy link

VictorioMolina commented Jun 21, 2022

@ShepSims have u tried encoding the files with base64, storing them as eas secrets, and running a package.json script (hook) for restoring the respective files?

I am about to handle this situation in a few days, and I feel that updating my eas secrets everytime the sensitive .gitignored files change is annoying… have u found any other way?

@dsokal dsokal removed their assignment Aug 12, 2022
@dsokal dsokal added eas build and removed stale labels Aug 12, 2022
@dsokal dsokal self-assigned this Aug 22, 2022
@bombillazo
Copy link

bombillazo commented Sep 9, 2022

Please and thank you EAS maintainers! As @diegoconcha mentioned, this feature is very valuable to streamline uploading files we already have in our repo but do not want to commit nor duplicate the ignore files!

@Jonak-Adipta-Kalita
Copy link

Please the maintainers of the repo, fix this issue.

@anadal-fundaciobit
Copy link

I too need fix this issue !!!!

@kbrandwijk
Copy link
Contributor

While we recognize that there could be some merit to an alternative implementation that doesn't require you to duplicate (most of) your ignore list, there are downsides to that implementation as well.

Given that the current solution already provides a working implementation for controlling the ignore behavior between git and EAS, we are currently not prioritizing any changes to this feature.

@kbrandwijk kbrandwijk closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2022
@hbriese
Copy link

hbriese commented Oct 20, 2022

Adding the negation to .easignore worked for

!google-services.secret.json

This works because my .gitignore looks like

**/*.secret.*

Had I ignored the file specifically then this would not work

@joaquinbian
Copy link

Hello, is there a way of including .easignore in github actions? I am using aws-amplify as well and my workflow fails because aws-exports is not found, I keep it ignore in .gitignore file

@hanamurayuki
Copy link

hanamurayuki commented Feb 1, 2023

After putting .easignore on the root directory of git repository, build starts working without error.
I haven't written !aws-exports.js on the .easignore file, but build works successfully.
So, I understand .easignore overrides all contents of .gitignore.

@andy-HM
Copy link

andy-HM commented Mar 25, 2023

I am running into the same thing. @hanamurayuki did you have the aws-exports.js committed before you tried this?

I have tried using .easignore and simply not including aws-exports.js. I have also tried explicit using !aws-exports.js in the .easignore with no luck.

@melyux
Copy link

melyux commented Oct 7, 2024

@hanamurayuki Didn't work for me. .easignore doesn't un-ignore anything, it can only ignore more things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eas build enhancement New feature or request
Projects
None yet
Development

No branches or pull requests