From 17b3ceb962def0c45d053c4c71f00347429ae2a1 Mon Sep 17 00:00:00 2001 From: Phil Pluckthun Date: Thu, 19 Dec 2024 03:11:11 +0000 Subject: [PATCH 1/3] Only check for dependencies once --- .../findProjectDirAndVerifyProjectSetupAsync.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/eas-cli/src/commandUtils/context/contextUtils/findProjectDirAndVerifyProjectSetupAsync.ts b/packages/eas-cli/src/commandUtils/context/contextUtils/findProjectDirAndVerifyProjectSetupAsync.ts index 6dc64c6af7..559109c143 100644 --- a/packages/eas-cli/src/commandUtils/context/contextUtils/findProjectDirAndVerifyProjectSetupAsync.ts +++ b/packages/eas-cli/src/commandUtils/context/contextUtils/findProjectDirAndVerifyProjectSetupAsync.ts @@ -103,6 +103,8 @@ export async function findProjectRootAsync({ } } +let ranEnsureEasCliIsNotInDependenciesAsync = false; + /** * Determine the project root directory and ensure some constraints about the project setup * like CLI version and dependencies. @@ -113,6 +115,9 @@ export async function findProjectRootAsync({ export async function findProjectDirAndVerifyProjectSetupAsync(): Promise { const projectDir = await findProjectRootAsync(); await applyCliConfigAsync(projectDir); - await ensureEasCliIsNotInDependenciesAsync(projectDir); + if (!ranEnsureEasCliIsNotInDependenciesAsync) { + ranEnsureEasCliIsNotInDependenciesAsync = true; + await ensureEasCliIsNotInDependenciesAsync(projectDir); + } return projectDir; } From 93982edb9114c1a4c638502afa23560fded20f08 Mon Sep 17 00:00:00 2001 From: Phil Pluckthun Date: Thu, 19 Dec 2024 03:11:37 +0000 Subject: [PATCH 2/3] Add CHANGELOG entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index dddf7c0b4d..42911a5b83 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ This is the log of notable changes to EAS CLI and related packages. ### ๐Ÿ› Bug fixes - Show `eas deploy` upload error messages. ([#2771](https://github.com/expo/eas-cli/pull/2771) by [@kadikraman](https://github.com/kadikraman)) +- Prevent EAS CLI dependencies check from running repeatedly. ([#2781](https://github.com/expo/eas-cli/pull/2781) by [@kitten](https://github.com/kitten)) ### ๐Ÿงน Chores From 34d13533e0331e0e19d68fcfaf480f841ef32c59 Mon Sep 17 00:00:00 2001 From: Phil Pluckthun Date: Thu, 19 Dec 2024 03:22:44 +0000 Subject: [PATCH 3/3] Apply lints --- .../findProjectDirAndVerifyProjectSetupAsync.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/eas-cli/src/commandUtils/context/contextUtils/findProjectDirAndVerifyProjectSetupAsync.ts b/packages/eas-cli/src/commandUtils/context/contextUtils/findProjectDirAndVerifyProjectSetupAsync.ts index 559109c143..e69c507b53 100644 --- a/packages/eas-cli/src/commandUtils/context/contextUtils/findProjectDirAndVerifyProjectSetupAsync.ts +++ b/packages/eas-cli/src/commandUtils/context/contextUtils/findProjectDirAndVerifyProjectSetupAsync.ts @@ -103,7 +103,7 @@ export async function findProjectRootAsync({ } } -let ranEnsureEasCliIsNotInDependenciesAsync = false; +let ranEnsureEasCliIsNotInDependencies = false; /** * Determine the project root directory and ensure some constraints about the project setup @@ -115,8 +115,8 @@ let ranEnsureEasCliIsNotInDependenciesAsync = false; export async function findProjectDirAndVerifyProjectSetupAsync(): Promise { const projectDir = await findProjectRootAsync(); await applyCliConfigAsync(projectDir); - if (!ranEnsureEasCliIsNotInDependenciesAsync) { - ranEnsureEasCliIsNotInDependenciesAsync = true; + if (!ranEnsureEasCliIsNotInDependencies) { + ranEnsureEasCliIsNotInDependencies = true; await ensureEasCliIsNotInDependenciesAsync(projectDir); } return projectDir;