Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the Express Legacy Wiki #251

Open
kristofferjansson opened this issue Jul 12, 2024 · 8 comments · May be fixed by expressjs/expressjs.com#1565
Open

Deprecate the Express Legacy Wiki #251

kristofferjansson opened this issue Jul 12, 2024 · 8 comments · May be fixed by expressjs/expressjs.com#1565
Assignees

Comments

@kristofferjansson
Copy link

Hello,

The link to template engines here in the wiki is broken. The page on expressjs.com (https://expressjs.com/en/resources/template-engines.html) was removed in this PR. So probably the link should be removed as well?

I'm not sure if it is possible to create a PR to change the wiki, so I created this issue instead. Maybe someone can help me with how make a change request for the wiki or just update it directly.

Thank you!

@IamLizu
Copy link
Member

IamLizu commented Jul 15, 2024

Good find, I think the link should be replaced with https://expressjs.com/en/guide/using-template-engines.html.

@wesleytodd
Copy link
Member

Honestly I think we talked about deleting the wiki someday. It is not at all well kept up and was mainly from the old days before all this stuff was on the website. I wonder if we should just delete it entirely?

@njanssoone
Copy link

njanssoone commented Jul 22, 2024

Good find, I think the link should be replaced with https://expressjs.com/en/guide/using-template-engines.html.

In this case this page should be patched too, as it refers to the wiki to list the template engines, which then redirects the user to the deleted page (as seen above)

See Template Engines (Express wiki) for a list of template engines you can use with Express.

@njanssoone
Copy link

@kristofferjansson if you still need the content of the page, this is the most recent snapshot of the wayback machine that doesn't 404.

@IamLizu
Copy link
Member

IamLizu commented Jul 24, 2024

Hey @njanssoone 👋

Thank you for pointing it out. However, I agree with @wesleytodd on this. I believe there should be a single source of truth. And maintaining a single place is much simpler to keep it updated.

We should do the following,

  • Make sure the website includes everything that has to be included from the Wiki
  • Set the Wiki homepage saying users to read docs from the website
  • Delete other pages from Wiki

@UlisesGascon
Copy link
Member

UlisesGascon commented Jul 25, 2024

@IamLizu, would you like to work on this and prepare a PR(s) for the content migration?

Edit: I transferred the issue for visibility

@UlisesGascon UlisesGascon changed the title Broken template engines link in wiki Deprecate the Express Legacy Wiki Jul 25, 2024
@UlisesGascon UlisesGascon transferred this issue from expressjs/express Jul 25, 2024
@IamLizu
Copy link
Member

IamLizu commented Jul 25, 2024

@UlisesGascon, sure, I will get started on this.

@crandmck
Copy link
Member

crandmck commented Aug 25, 2024

Hi guys, sorry I didn't see this sooner.

Yes, the wiki has a bunch of old/irrelevant info that should be deleted. The original distinction between the wiki and the expressjs.com doc site was that the wiki was mostly for WIP notes and for internal info, as well as a kind of archive for low-value material that was not deemed important enough to maintain or translate.

The easiest thing to do would be to delete anything that no longer has any value or is inaccurate, and clearly mark the rest as ARCHIVE or whatever. Moving it to the doc site will incur additional maintenance and potential translation burdens that I' doubt is worthwhile.

There is also a wiki for the expressjs.com repo with one or two things wiki that we should keep somehwere. For example the Documentation style guide -- this is pretty "down in the weeds" info for doc contributors; not sure it belongs on the website. Much of that page is English-specific, too; translation would be problematic. When I have a moment, I'll review that wiki for anything else worth keeping.

I see @IamLizu opened expressjs/expressjs.com#1565. I'll comment there, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants