Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster request mount #6004

Closed
wants to merge 1 commit into from
Closed

Faster request mount #6004

wants to merge 1 commit into from

Conversation

cesco69
Copy link

@cesco69 cesco69 commented Oct 1, 2024

With Object.defineProperty the engine (Node/V8) has to handle the possibility of custom getters, setters, and property descriptors, which can prevent certain optimizations that would otherwise make property access faster.

This pull request is an attempt to resolve #5998 and make express faster without breaking change

I'm on Windows and the express benchmark works only on linux. Can someone run this for me and show me if my PR improves performance?

With Object.defineProperty the engine (Node/V8) has to handle the possibility of custom getters, setters, and property descriptors, which can prevent certain optimizations that would otherwise make property access faster.

This pull request is an attempt to resolve 5998
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to make Express 2x faster
2 participants