-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review and Update v5.x Documentation against v4.x #1479
Comments
Thanks for captuing this @UlisesGascon |
I will start to work on this |
I just invested some time to check what is missing potentially in the migration guide and the 5.x API based on the changelog Legend
Changelog digestion5.0.0-beta.3 / 2024-03-25This incorporates all changes after 4.19.1 up to 4.19.2. 🍿 (Ignored) 5.0.0-beta.2 / 2024-03-20This incorporates all changes after 4.17.2 up to 4.19.1. 🍿 (Ignored) 5.0.0-beta.1 / 2022-02-14This is the first Express 5.0 beta release, based off 4.17.2 and includes
5.0.0-alpha.8 / 2020-03-25This is the eighth Express 5.0 alpha release, based off 4.17.1 and includes 5.0.0-alpha.7 / 2018-10-26This is the seventh Express 5.0 alpha release, based off 4.16.4 and includes The major change with this alpha is the basic support for returned, rejected
5.0.0-alpha.6 / 2017-09-24This is the sixth Express 5.0 alpha release, based off 4.15.5 and includes
5.0.0-alpha.5 / 2017-03-06This is the fifth Express 5.0 alpha release, based off 4.15.2 and includes 5.0.0-alpha.4 / 2017-03-01This is the fourth Express 5.0 alpha release, based off 4.15.0 and includes
5.0.0-alpha.3 / 2017-01-28This is the third Express 5.0 alpha release, based off 4.14.1 and includes
5.0.0-alpha.2 / 2015-07-06This is the second Express 5.0 alpha release, based off 4.13.1 and includes
5.0.0-alpha.1 / 2014-11-06This is the first Express 5.0 alpha release, based off 4.10.1.
|
The documentation and migration guide are also missing some changes from 5.0.0 and e.g. suggest using |
Thanks @krzysdz, anywhere it would have been
Also documented here: https://github.com/pillarjs/path-to-regexp?tab=readme-ov-file#express--4x. |
In our recent TC meeting, we discussed the necessity to review the
v5.x
documentation due to discrepancies with changes made inv4.x
that were not ported over.Additionally, we need to implement a GitHub Action that will automatically add a comment to any PR that modifies files within the
../v4/..
folder, reminding contributors to review if these changes also affectv5.x
. (see: #1514 )The text was updated successfully, but these errors were encountered: