Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fast_star paths with path patterns #1369

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

aelmardhi
Copy link
Contributor

fast star is no longer supporrted
using path patterns to allow match all

fast star is no longer supporrted
@crandmck crandmck added the 5.x Docs for 5.x version label Mar 5, 2024
@crandmck crandmck added the needs tech review A doc edit that requires technical review before merging label May 24, 2024
Copy link
Member

@IamLizu IamLizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Let's get it landed.

Edit: I removed the "needs tech review" label as I can confirm the changes are correct.

@IamLizu IamLizu added pr and removed needs tech review A doc edit that requires technical review before merging labels Sep 1, 2024
@crandmck
Copy link
Member

crandmck commented Sep 2, 2024

Thanks for reviewing/confirming this fix @IamLizu !

@crandmck crandmck merged commit 7086c51 into expressjs:gh-pages Sep 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.x Docs for 5.x version pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants