Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update best-practice-security with TLS Cipher Suites.md #1534

Closed

Conversation

stellastrareviews
Copy link

No description provided.

Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit be4d26c
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/667a9c16123b350008ec9d84
😎 Deploy Preview https://deploy-preview-1534--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chrisdel101
Copy link
Contributor

Hi @stellastrareviews. As this is an unsolicited PR with no text body description whatsoever I'm inclined to close this.
I'll ask for @crandmck to take a look first.

@crandmck crandmck requested a review from jonchurch July 3, 2024 19:11
@crandmck
Copy link
Member

crandmck commented Jul 3, 2024

Thanks @chrisdel101 ...
I'm not a security expert, so I have no idea if this is good advice. It's important to provide good security guidance, so if it IS, then we should include it.

Perhaps @jonchurch can advise? Otherwise, then, yes, we can just close this.

@ctcpip
Copy link
Member

ctcpip commented Jul 3, 2024

Suggest closing without merging. Unsolicited PR recommending a proprietary tool which is redundant for the recommendations already provided.

@crandmck crandmck closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants