Skip to content

Conversation

JosiahParry
Copy link
Contributor

@JosiahParry JosiahParry commented Aug 15, 2025

This PR

The version of of extendr-api is fetched from https://crates.io/api/v1/crates/extendr-api using jsonlite::read_json() if this fails for any reason it will always fall back to "*". The version is set in the options in .onLoad() and is fetched from the options when using use_extendr()

This also sets the MSRV of extendr into the SystemRequirements as well as xz.

As a follow up we can create an rextendr.msrv option to store the MSRV instead of hard coding it.

@JosiahParry JosiahParry changed the title add xz as a system dep and add real extendr version chore: add xz as a system dep and add real extendr version Aug 15, 2025
@JosiahParry JosiahParry merged commit 48fc985 into main Aug 15, 2025
18 of 19 checks passed
@JosiahParry JosiahParry deleted the xz branch August 15, 2025 19:58
Copy link

codecov bot commented Aug 15, 2025

Codecov Report

❌ Patch coverage is 45.45455% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.02%. Comparing base (9db60d0) to head (197c542).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/zzz.R 0.00% 18 Missing ⚠️

❌ Your patch status has failed because the patch coverage (45.45%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
R/setup.R 90.24% <100.00%> (+1.67%) ⬆️
R/use_extendr.R 98.67% <100.00%> (+0.01%) ⬆️
R/zzz.R 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xz missing from documented SystemRequirements Specify extendr-api version in Cargo.toml
2 participants