Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed issue #10

Open
topDev15 opened this issue Dec 5, 2019 · 0 comments
Open

Speed issue #10

topDev15 opened this issue Dec 5, 2019 · 0 comments

Comments

@topDev15
Copy link

topDev15 commented Dec 5, 2019

I'm trying to change color of shape using following code:
@discardableResult public func replaceColors(node: Node, color: Fill?) -> Bool {
if let shape = node as? Shape {
shape.fill = color
return true
}
return false
}

At that moment, following code will be called:

group.contentsVar.onChange { [weak self] _ in
self?.updateRenderers()
}

private func updateRenderers() {
renderers.forEach { $0.dispose() }
renderers.removeAll()

    if let updatedRenderers = group?.contents.compactMap ({ child -> NodeRenderer? in
        guard let interval = renderingInterval else {
            print("setNeedsDisplay=6-2")
            return RenderUtils.createNodeRenderer(child, view: view, animationCache: animationCache)
        }

        let index = AnimationUtils.absoluteIndex(child, useCache: true)
        if index > interval.from && index < interval.to {
            print("setNeedsDisplay=6-3")
            return RenderUtils.createNodeRenderer(child, view: view, animationCache: animationCache, interval: interval)
        }

        return .none

    }) {
        renderers = updatedRenderers
    }
}

Btw when the color of shape is changed, updateRenderers() will be called much time.
It lowered the speed of the app.
How can we call updateRenderers() only once for changed shape?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant