Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When implementing foo.bar.method(), use this.baz instead of foo.bar.baz #212

Open
eyalroz opened this issue Apr 26, 2024 · 0 comments
Open

When implementing foo.bar.method(), use this.baz instead of foo.bar.baz #212

eyalroz opened this issue Apr 26, 2024 · 0 comments
Labels
task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Apr 26, 2024

We have a lot of repetition with methods in RemoveDupes.subobject.someMethod() implementations, where I call RemoveDupes.subobject.anotherMethod(). Instead, I could call this.anotherMethod().

Too bad I can't just use anotherMethod() plain and simple.
@eyalroz eyalroz added the task label Apr 26, 2024
eyalroz added a commit that referenced this issue Apr 26, 2024
@eyalroz
Fixes #212: Replace uses of RemoveDupes.subobject.foo() with `this.…
11d3cb0 
…foo()` wherever possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz