fix(tb): notifications

Author: eythaann

Cargo.lock

@@ -169,6 +169,7 @@ windows = { workspace = true, features = [
     "Win32_UI_Shell_PropertiesSystem",
     "Win32_UI_Accessibility",
     "Win32_UI_Controls",
+    "Win32_UI_Notifications",
     "Win32_Graphics_Dwm",
     "Win32_Graphics_Gdi",
     "Win32_UI_HiDpi",

Cargo.toml

@@ -1,6 +1,9 @@
 # Changelog
 
-## [Unreleased]
+## [Unreleased]
+### fix
+- notifications not showing or working as expected.
+
 ## [2.4.2]
 ### features
 - tiling window manager animations.

changelog.md

@@ -46,7 +46,7 @@
     "@commitlint/config-conventional": "^19.2.2",
     "@nyariv/sandboxjs": "^0.8.24",
     "@reduxjs/toolkit": "^2.5.0",
-    "@seelen-ui/lib": "^2.4.1-next.20250902085054",
+    "@seelen-ui/lib": "^2.4.1-next.20250911151945",
     "@seelen/translation-toolkit": "^1.1.10",
     "@stylistic/eslint-plugin": "^1.6.2",
     "@types/d3": "^7.4.3",

package-lock.json

@@ -1,4 +1,5 @@
 use std::collections::HashMap;
+use std::os::windows::process::CommandExt;
 use std::path::PathBuf;
 
 use seelen_core::state::RelaunchArguments;
@@ -8,6 +9,7 @@ use seelen_core::{command_handler_list, system_state::Color};
 use tauri::{Builder, WebviewWindow, Wry};
 use tauri_plugin_shell::ShellExt;
 use translators::Translator;
+use windows::Win32::System::Threading::{CREATE_NEW_PROCESS_GROUP, CREATE_NO_WINDOW};
 
 use crate::app::{get_app_handle, Seelen};
 use crate::error::Result;
@@ -27,8 +29,17 @@ use crate::windows_api::WindowsApi;
 use crate::{log_error, utils};
 
 #[tauri::command(async)]
-fn open_file(path: String) -> Result<()> {
-    open::that_detached(path)?;
+pub fn open_file(path: String) -> Result<()> {
+    std::process::Command::new("cmd")
+        .raw_arg("/c")
+        .raw_arg("start")
+        .raw_arg("\"\"")
+        .raw_arg(format!("\"{path}\""))
+        .creation_flags(CREATE_NO_WINDOW.0 | CREATE_NEW_PROCESS_GROUP.0)
+        .stdin(std::process::Stdio::null())
+        .stdout(std::process::Stdio::null())
+        .stderr(std::process::Stdio::null())
+        .spawn()?;
     Ok(())
 }
 
@@ -44,7 +55,7 @@ fn select_file_on_explorer(path: String) -> Result<()> {
 
 #[tauri::command(async)]
 async fn run(
-    program: PathBuf,
+    program: String,
     args: Option<RelaunchArguments>,
     working_dir: Option<PathBuf>,
 ) -> Result<()> {
@@ -55,13 +66,15 @@ async fn run(
         },
         None => String::new(),
     };
+
     log::trace!("Running: {program:?} {args} in {working_dir:?}");
 
     // we create a link file to trick with explorer into a separated process
     // and without elevation in case Seelen UI was running as admin
     // this could take some delay like is creating a file but just are some milliseconds
     // and this exposed funtion is intended to just run certain times
-    let lnk_file = WindowsApi::create_temp_shortcut(&program, &args, working_dir.as_deref())?;
+    let lnk_file =
+        WindowsApi::create_temp_shortcut(&PathBuf::from(program), &args, working_dir.as_deref())?;
     get_app_handle()
         .shell()
         .command(SEELEN_COMMON.system_dir().join("explorer.exe"))

package.json

@@ -9,7 +9,9 @@ use std::{
 
 use lazy_static::lazy_static;
 use parking_lot::Mutex;
-use seelen_core::system_state::{AppNotification, Toast, ToastBindingEntry};
+use seelen_core::system_state::{
+    AppNotification, Toast, ToastActionActivationType, ToastBindingChild, ToastText,
+};
 use tauri::Manager;
 use windows::{
     ApplicationModel::AppInfo,
@@ -27,10 +29,10 @@ use crate::{
     app::get_app_handle,
     error::Result,
     event_manager, log_error,
-    modules::uwp::get_hightest_quality_posible,
+    modules::{start::application::START_MENU_MANAGER, uwp::get_hightest_quality_posible},
     trace_lock,
     utils::{convert_file_to_src, icon_extractor::extract_and_save_icon_umid, spawn_named_thread},
-    windows_api::traits::EventRegistrationTokenExt,
+    windows_api::{traits::EventRegistrationTokenExt, types::AppUserModelId, WindowsApi},
 };
 
 lazy_static! {
@@ -183,20 +185,26 @@ impl NotificationManager {
     }
 
     fn clean_toast(toast: &mut Toast, umid: &str) -> Result<()> {
+        if toast.launch.is_none() {
+            toast.launch = Some(format!("shell:AppsFolder\\{umid}"));
+            toast.activation_type = ToastActionActivationType::Protocol;
+        }
+
         let package_path = AppInfo::GetFromAppUserModelId(&umid.into())
             .and_then(|info| info.Package())
             .and_then(|package| package.InstalledPath())
             .map(|path| PathBuf::from(path.to_os_string()));
 
-        for entry in &mut toast.visual.binding.entries {
-            let ToastBindingEntry::Image(image) = entry else {
+        for entry in &mut toast.visual.binding.children {
+            let ToastBindingChild::Image(image) = entry else {
                 continue;
             };
 
             if image.src.is_empty() {
                 continue;
             }
 
+            log::trace!("Resolving image src:e \"{}\"", image.src);
             let uri = Uri::CreateUri(&image.src.clone().into())?;
             let scheme = uri.SchemeName()?.to_string_lossy();
             let uri_path = PathBuf::from(
@@ -252,7 +260,14 @@ impl NotificationManager {
                     image.src = convert_file_to_src(&path);
                 }
                 "file" => {
-                    image.src = convert_file_to_src(&uri_path);
+                    image.src = if uri_path.exists() {
+                        convert_file_to_src(&uri_path)
+                    } else {
+                        // telegram desktop from ms store uses file intead of ms-appdata
+                        // so this causes the image to be missing, windows doesn't show image as well
+                        // so we decide to follow same behavior.
+                        "".to_string()
+                    }
                 }
                 _ => {}
             }
@@ -280,15 +295,13 @@ impl NotificationManager {
         let app_umid = app_info.AppUserModelId()?;
 
         let visuals = notification.Visual()?;
-        let text_sequence = visuals
-            .GetBinding(&KnownNotificationBindings::ToastGeneric()?)?
-            .GetTextElements()?;
-        let mut notification_text = Vec::new();
-        for text in text_sequence {
-            let text = text.Text()?.to_string_lossy().trim().to_string();
-            if !text.is_empty() {
-                notification_text.push(text);
-            }
+        let binding = visuals.GetBinding(&KnownNotificationBindings::ToastGeneric()?)?;
+        let text_sequence = binding.GetTextElements()?;
+
+        let mut notification_text = String::new();
+        for text in &text_sequence {
+            let text = text.Text()?.to_string_lossy().trim().replace("\r\n", "\n");
+            notification_text.push_str(&text);
         }
 
         let history = self.manager.History()?;
@@ -304,29 +317,46 @@ impl NotificationManager {
         for toast_notification in toast_notifications {
             // this can be null when the notification count is bigger than the max allowed by default 20
             if let Ok(content) = toast_notification.Content() {
-                let data = content.GetXml()?.to_string();
-                let mut toast: Toast = quick_xml::de::from_str(&data)?;
-
-                let mut toast_text = Vec::new();
-                for entry in &toast.visual.binding.entries {
-                    if let ToastBindingEntry::Text(text) = entry {
-                        if !text.content.is_empty() {
-                            toast_text.push(text.content.clone().replace("\r\n", "\n"));
-                        }
-                    }
-                }
+                let toast_xml = content.GetXml()?.to_string();
+                let mut toast: Toast = quick_xml::de::from_str(&toast_xml)?;
+                let toast_text = get_text_from_toast(&toast);
 
                 if notification_text == toast_text {
                     Self::clean_toast(&mut toast, &app_umid.to_string())?;
                     notification_content = Some(toast);
+
+                    println!(
+                        "??????????? Group {:?} - Tag: {:?}",
+                        toast_notification.Group(),
+                        toast_notification.Tag()
+                    );
                     break;
                 }
             }
         }
 
-        if notification_content.is_none() {
-            log::debug!("NONE FOR {notification_text:#?}");
-        }
+        let notification_content = match notification_content {
+            Some(content) => content,
+            None => {
+                log::debug!("Toast content not found, generating one from plain text");
+                let mut toast = Toast::default();
+                let content = &mut toast.visual.binding.children;
+                for text in text_sequence {
+                    let text = text
+                        .Text()?
+                        .to_string_lossy()
+                        .replace("\r\n", "\n")
+                        .trim()
+                        .to_owned();
+                    content.push(ToastBindingChild::Text(ToastText {
+                        id: None,
+                        content: text,
+                    }));
+                }
+                Self::clean_toast(&mut toast, &app_umid.to_string())?;
+                toast
+            }
+        };
 
         // pre-extraction to avoid flickering on the ui
         extract_and_save_icon_umid(&app_umid.to_string().into());
@@ -337,9 +367,36 @@ impl NotificationManager {
             app_name: display_info.DisplayName()?.to_string(),
             app_description: display_info.Description()?.to_string(),
             date: u_notification.CreationTime()?.UniversalTime,
-            content: notification_content.ok_or("Failed to get notification content")?,
+            content: notification_content,
         });
         self.notifications.sort_by(|a, b| b.date.cmp(&a.date));
         Ok(())
     }
 }
+
+fn get_text_from_toast(toast: &Toast) -> String {
+    let mut text = String::new();
+    for entry in &toast.visual.binding.children {
+        // text inside groups are intended to be ignored for the comparison
+        if let ToastBindingChild::Text(entry) = entry {
+            text.push_str(entry.content.replace("\r\n", "\n").trim());
+        }
+    }
+    text
+}
+
+pub fn get_toast_activator_clsid(app_umid: &AppUserModelId) -> Result<String> {
+    match app_umid {
+        AppUserModelId::PropertyStore(umid) => {
+            let guard = START_MENU_MANAGER.load();
+            if let Some(item) = guard.get_by_file_umid(umid) {
+                let clsid = WindowsApi::get_file_toast_activator(&item.path)?;
+                return Ok(clsid);
+            }
+        }
+        _ => {
+            // todo search for the clsid in the AppManifest
+        }
+    };
+    Err(format!("Unable to get toast activator clsid for: {app_umid:?}").into())
+}