Skip to content

Commit 21af295

Browse files
committed
fixed UpdateChecker crashes when no connection to manifest
1 parent 64292a3 commit 21af295

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

luckprefix-modern/src/main/java/de/eztxm/luckprefix/util/UpdateChecker.java

+8-11
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import java.io.BufferedReader;
77
import java.io.IOException;
88
import java.io.InputStreamReader;
9+
import java.net.URI;
910
import java.net.URL;
1011

1112
@Getter
@@ -21,22 +22,18 @@ public UpdateChecker(String version) {
2122
public boolean latestVersion() {
2223
String latestVersion = getLatestVersion();
2324
if (latestVersion == null) return true;
25+
if (this.cachedLatestVersion.equalsIgnoreCase("N/A")) return true;
2426
return latestVersion.equalsIgnoreCase(currentVersion);
2527
}
2628

2729
private String getLatestVersion() {
28-
try {
29-
String urlString = "https://cdn.eztxm.de/plugin/luckprefix/manifest.json";
30-
URL url = new URL(urlString);
31-
BufferedReader reader = new BufferedReader(new InputStreamReader(url.openStream()));
30+
String urlString = "https://cdn.eztxm.de/plugin/luckprefix/manifest.json";
31+
try (BufferedReader reader = new BufferedReader(new InputStreamReader(URI.create(urlString).toURL().openStream()))) {
32+
if (reader.lines().toList().isEmpty()) return this.cachedLatestVersion;
3233
String line = reader.readLine();
3334
JSONObject jsonObject = new JSONObject(line);
34-
String latestVersion = jsonObject.getString("Latest-Version");
35-
this.cachedLatestVersion = latestVersion;
36-
return latestVersion;
37-
} catch (IOException e) {
38-
e.fillInStackTrace();
39-
}
40-
return "N/A";
35+
this.cachedLatestVersion = jsonObject.getString("Latest-Version");
36+
} catch (IOException ignored) {}
37+
return this.cachedLatestVersion;
4138
}
4239
}

0 commit comments

Comments
 (0)