refactor: optimized main class

Author: ezTxmMC

luckprefix-modern/src/main/java/de/eztxm/luckprefix/LuckPrefix.java

@@ -11,9 +11,6 @@
 import net.kyori.adventure.platform.bukkit.BukkitAudiences;
 import net.luckperms.api.LuckPerms;
 import net.luckperms.api.LuckPermsProvider;
-import net.luckperms.api.model.group.Group;
-import org.bukkit.Bukkit;
-import org.bukkit.entity.Player;
 import org.bukkit.plugin.java.JavaPlugin;
 
 @Getter
@@ -40,39 +37,21 @@ public void onEnable() {
         prefix = "<#77ef77>LuckPrefix <dark_gray>| <gray>";
         databaseFile = ConfigUtil.addDatabaseDefault("database.yml");
         groupsFile = ConfigUtil.addGroupsDefault("groups.yml");
-        if (databaseFile.getValue("Database.Enabled").asBoolean()) {
-            connection = DatabaseManager.createDatabaseConnection();
-        }
+        connection = DatabaseManager.createDatabaseConnection();
         adventure = BukkitAudiences.create(instance);
         luckPerms = LuckPermsProvider.get();
         registry = new Registry(instance);
         registry.registerCommand("luckprefix", new LuckPrefixCommand());
         registry.registerListener(new JoinListener());
         registry.registerListener(new QuitListener());
         registry.registerListener(new ChatListener());
-        if (connection != null) {
-            databaseManager = new DatabaseManager(connection);
-        }
+        databaseManager = new DatabaseManager(connection);
         playerManager = new PlayerManager();
         groupManager = new GroupManager();
         groupListener = new GroupListener();
         groupListener.createGroup();
         groupListener.deleteGroup();
-        for (Group group : luckPerms.getGroupManager().getLoadedGroups()) {
-            if (groupsFile.contains(group.getName())) {
-                groupManager.createGroup(group.getName());
-                continue;
-            }
-            if (getConfig().getBoolean("Warning-If-Group-Can-Not-Loaded")) {
-                getLogger().warning("Group '" + group.getName() + "' can't be loaded.");
-            }
-        }
-        Bukkit.getScheduler().runTaskTimerAsynchronously(instance, () -> {
-            if (Bukkit.getOnlinePlayers().isEmpty()) return;
-            for (Player player : Bukkit.getOnlinePlayers()) {
-                playerManager.setPlayerListName(player.getUniqueId());
-            }
-        }, 1, getConfig().getLong("UpdateTime") * 20);
+        groupManager.loadGroups();
     }
 
     @Override

luckprefix-modern/src/main/java/de/eztxm/luckprefix/util/DatabaseManager.java

@@ -7,28 +7,32 @@
 import org.bukkit.configuration.file.FileConfiguration;
 
 public class DatabaseManager {
-    private final SQLConnection connection;
+    private SQLConnection connection;
 
     public DatabaseManager(SQLConnection connection) {
+        if (connection == null) return;
         this.connection = connection;
     }
 
     public static SQLConnection createDatabaseConnection() {
-        FileConfiguration config = LuckPrefix.getInstance().getConfig();
-        String type = config.getString("Database.Type");
-        return switch (type.toUpperCase()) {
-            case "SQLITE" -> new SQLiteConnection(
-                    config.getString("Database.SQLite.Path"),
-                    config.getString("Database.SQLite.FileName")
-            );
-            case "MARIADB" -> new MariaDBConnection(
-                    config.getString("Database.MariaDB.Host"),
-                    config.getInt("Database.MariaDB.Port"),
-                    config.getString("Database.MariaDB.Database"),
-                    config.getString("Database.MariaDB.User"),
-                    config.getString("Database.MariaDB.Password")
-            );
-            default -> null;
-        };
+        if (LuckPrefix.getInstance().getDatabaseFile().getValue("Database.Enabled").asBoolean()) {
+            FileConfiguration config = LuckPrefix.getInstance().getConfig();
+            String type = config.getString("Database.Type");
+            return switch (type.toUpperCase()) {
+                case "SQLITE" -> new SQLiteConnection(
+                        config.getString("Database.SQLite.Path"),
+                        config.getString("Database.SQLite.FileName")
+                );
+                case "MARIADB" -> new MariaDBConnection(
+                        config.getString("Database.MariaDB.Host"),
+                        config.getInt("Database.MariaDB.Port"),
+                        config.getString("Database.MariaDB.Database"),
+                        config.getString("Database.MariaDB.User"),
+                        config.getString("Database.MariaDB.Password")
+                );
+                default -> null;
+            };
+        }
+        return null;
     }
 }

luckprefix-modern/src/main/java/de/eztxm/luckprefix/util/GroupManager.java

@@ -4,6 +4,7 @@
 import lombok.Getter;
 import net.kyori.adventure.text.minimessage.MiniMessage;
 import net.kyori.adventure.text.serializer.legacy.LegacyComponentSerializer;
+import net.luckperms.api.model.group.Group;
 import org.bukkit.Bukkit;
 import org.bukkit.ChatColor;
 import org.bukkit.configuration.file.FileConfiguration;
@@ -116,4 +117,23 @@ public void deleteGroup(String group) {
         this.groupID.remove(group);
         this.groupColor.remove(group);
     }
+    
+    public void loadGroups() {
+        LuckPrefix instance = LuckPrefix.getInstance();
+        for (Group group : instance.getLuckPerms().getGroupManager().getLoadedGroups()) {
+            if (instance.getGroupsFile().contains(group.getName())) {
+                instance.getGroupManager().createGroup(group.getName());
+                continue;
+            }
+            if (instance.getConfig().getBoolean("Warning-If-Group-Can-Not-Loaded")) {
+                instance.getLogger().warning("Group '" + group.getName() + "' can't be loaded.");
+            }
+        }
+        Bukkit.getScheduler().runTaskTimerAsynchronously(instance, () -> {
+            if (Bukkit.getOnlinePlayers().isEmpty()) return;
+            for (Player player : Bukkit.getOnlinePlayers()) {
+                instance.getPlayerManager().setPlayerListName(player.getUniqueId());
+            }
+        }, 1, instance.getConfig().getLong("UpdateTime") * 20);
+    }
 }