Skip to content

Commit a84ed50

Browse files
authored
Refactor/problem (#82)
* refactor : timeLimit 데이터 타입 변경 (Long) * refactor : Swagger 수정 (memoryLimit, timeLimit) * refactor : Enum 변경 (Difficulty + 해당 난이도 점수정보 포함) * refactor : 띄어 쓰기 추가
1 parent e41c128 commit a84ed50

File tree

5 files changed

+20
-18
lines changed

5 files changed

+20
-18
lines changed

src/main/java/org/ezcode/codetest/application/problem/dto/request/ProblemCreateRequest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@ public record ProblemCreateRequest(
2929
Difficulty difficulty,
3030

3131
@NotNull(message = "메모리 제한을 설정해야 합니다.")
32-
@Schema(description = "메모리 제한", example = "30000")
32+
@Schema(description = "메모리 제한(KB)", example = "30000")
3333
Long memoryLimit,
3434

3535
@NotNull(message = "시간 제한을 설정해야 합니다.")
36-
@Schema(description = "시간 제한", example = "1000.0")
37-
Double timeLimit,
36+
@Schema(description = "시간 제한(ms)", example = "1000")
37+
Long timeLimit,
3838

3939
@NotNull(message = "출처를 명시해야 합니다.")
4040
@Schema(description = "출처", example = "ORIGINAL")

src/main/java/org/ezcode/codetest/application/problem/dto/request/ProblemUpdateRequest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ public record ProblemUpdateRequest(
2222
@Schema(description = "난이도", example = "BRONZE")
2323
Difficulty difficulty,
2424

25-
@Schema(description = "메모리 제한", example = "30000")
25+
@Schema(description = "메모리 제한(KB)", example = "30000")
2626
Long memoryLimit,
2727

28-
@Schema(description = "시간 제한", example = "1000.0")
29-
Double timeLimit,
28+
@Schema(description = "시간 제한(ms)", example = "1000")
29+
Long timeLimit,
3030

3131
@Schema(description = "출처", example = "ORIGINAL")
3232
Reference reference

src/main/java/org/ezcode/codetest/application/problem/dto/response/ProblemDetailResponse.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ public record ProblemDetailResponse(
3333
@Schema(description = "난이도", example = "BRONZE")
3434
String difficulty,
3535

36-
@Schema(description = "메모리 제한", example = "30000")
36+
@Schema(description = "메모리 제한(KB)", example = "30000")
3737
Long memoryLimit,
3838

39-
@Schema(description = "시간 제한", example = "1000.0")
40-
Double timeLimit,
39+
@Schema(description = "시간 제한(ms)", example = "1000")
40+
Long timeLimit,
4141

4242
@Schema(description = "출처", example = "ORIGINAL")
4343
Reference reference,

src/main/java/org/ezcode/codetest/domain/problem/model/entity/Problem.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public class Problem extends BaseEntity {
5858
private Long memoryLimit;
5959

6060
@Column(nullable = false)
61-
private Double timeLimit;
61+
private Long timeLimit;
6262

6363
@Enumerated(EnumType.STRING)
6464
@Column(nullable = false)
@@ -72,7 +72,7 @@ public class Problem extends BaseEntity {
7272

7373
@Builder
7474
public Problem(User creator, Category category, String title, String description, int score, String difficulty,
75-
Long memoryLimit, Double timeLimit, Reference reference) {
75+
Long memoryLimit, Long timeLimit, Reference reference) {
7676
this.creator = creator;
7777
this.category = category;
7878
this.title = title;
@@ -87,7 +87,7 @@ public Problem(User creator, Category category, String title, String description
8787

8888
// 여러개를 하나의 객체로 만드는 것
8989
public static Problem of(User creator, Category category, String title, String description, int score, String difficulty,
90-
Long memoryLimit, Double timeLimit, Reference reference) {
90+
Long memoryLimit, Long timeLimit, Reference reference) {
9191

9292
return Problem.builder()
9393
.creator(creator)
@@ -104,7 +104,7 @@ public static Problem of(User creator, Category category, String title, String d
104104

105105
// 문제 수정 로직
106106
public void update(User creator, Category category, String title, String description, Difficulty difficulty,
107-
Long memoryLimit, Double timeLimit, Reference reference) {
107+
Long memoryLimit, Long timeLimit, Reference reference) {
108108

109109
if (creator != null) this.creator = creator;
110110
if (category != null) this.category = category;

src/main/java/org/ezcode/codetest/domain/problem/model/enums/Difficulty.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,13 @@
99

1010
@Getter
1111
public enum Difficulty {
12-
BRONZE("브론즈", 20),
13-
SILVER("실버", 40),
14-
GOLD("골드", 60),
15-
PLATINUM("플래티넘", 80),
16-
DIAMOND("다이아", 100);
12+
LV1("1", 10),
13+
LV2("2", 20),
14+
LV3("3", 40),
15+
LV4("4", 80),
16+
LV5("5", 160),
17+
LV6("6", 320),
18+
LV7("7", 640);
1719

1820
private final String difficulty;
1921

0 commit comments

Comments
 (0)