Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for pubspec.yml in parent directories #10

Open
f3ath opened this issue Nov 17, 2018 · 7 comments
Open

Search for pubspec.yml in parent directories #10

f3ath opened this issue Nov 17, 2018 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@f3ath
Copy link
Owner

f3ath commented Nov 17, 2018

If pubspec.yaml is not found in the current directory, search in parent directories. This behavior should only be applied for the default directory.

@f3ath f3ath added help wanted Extra attention is needed enhancement New feature or request good first issue Good for newcomers labels Nov 17, 2018
@Agraphie
Copy link

How many parents would it need to go up? And is this use case likely?

@f3ath
Copy link
Owner Author

f3ath commented Jun 13, 2019

Up to the root folder I'd say. I think it is somewhat likely. Think of Git, you can run any git command from any folder withing the repo, I find it pretty convenient.

@Agraphie
Copy link

To the root folder of the project, so not the absolute root of the file system? I'd be happy to play around with it a bit and see if I can find a solution.

@f3ath
Copy link
Owner Author

f3ath commented Jun 13, 2019

The filesystem root.

@Agraphie
Copy link

I have added this here https://github.com/Agraphie/pubspec-version/tree/feature/search_parent_for_pubspec

I also added tests. Do you want to create a branch here as well? I can create a pull request to that branch and we can compare and discuss better.

@f3ath
Copy link
Owner Author

f3ath commented Jun 17, 2019

Thanks. I'd like to see this as a separate PR without the unrelated (version manipulation) changes.

@Agraphie
Copy link

Yes true. Weird I thought I used the master branch here as HEAD. I'll reset it to exclude the version changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants