This repository has been archived by the owner on Dec 4, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Add a way for S2I templates to obtain Route host names #269
Comments
3 tasks
I like the 2nd option too. Do you have an example of how the |
I've got this working already (#270) so yes you can see it here: https://github.com/quintesse/wfswarm-rest-http-secured/blob/testing-s2i/app/.openshiftio/application.yaml#L33 |
Wow, that's so cool! Thanks! |
quintesse
added a commit
that referenced
this issue
Oct 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In templates
Route
elements can have their host names generated which makes it difficult to refer to those URLs from other templates. It would be nice to have a way to refer to the generated host names of previously appliedRoute
objects. (It will be impossible to do from within the same template)First we need to make sure that templates are applied in some known order, preferably
resource.yaml
,service.yaml
and finallyapplication.yaml
. That way an application template can refer to aRoute
in a service template for example. (Done fc5bd3d)And then we either:
ROUTE_HOST_XXX_YYY
which would then get their value set to the host name of theRoute
namedxxx-yyy
. Or wefabric8-value
which can be added to template parameters and which would hold a default value to be used in case that no value was explicitly set for the parameter. The value would be a string that can contain special variables like{{route/xxx-yyy[.spec.host]}}
that would look up theRoute
namedxxx-yyy
and return its host.The first option is the easiest but has the disadvantage of not giving us full flexibility. Often we want the template parameter to be an entire URL, not just a host name.
The text was updated successfully, but these errors were encountered: