Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new vertx generator for f-m-p #55

Open
davsclaus opened this issue Nov 21, 2016 · 9 comments
Open

Use the new vertx generator for f-m-p #55

davsclaus opened this issue Nov 21, 2016 · 9 comments

Comments

@davsclaus
Copy link
Contributor

We can simpify the pom.xml to use the f-m-p plugin to build the JAR and whatnot
https://maven.fabric8.io/#generator-vertx

@davsclaus
Copy link
Contributor Author

@kameshsampath maybe you want to take a look and do a PR to update this sample to use your new plugin

@rhuss
Copy link
Contributor

rhuss commented Nov 21, 2016

@davsclaus we just need to make the first release to Maven central ;-) (which we will do today)

@kameshsampath
Copy link
Contributor

will check this out later today @davsclaus and do the required update

@kameshsampath
Copy link
Contributor

@davsclaus i have updated the project with v-m-p, but enroute found an fabric8io/vertx-maven-plugin#15, will send a PR once we do the next release of the v-m-p

@kameshsampath
Copy link
Contributor

@davsclaus and @rhuss - fixed this via #57 , please review and merge. Tested locally via k8s and using plugin both works

@davsclaus
Copy link
Contributor Author

Thanks just ran it locally and it works, however not sure why SVC shows the port as 0 and not the actual external port

[INFO] F8:[SVC] vertx-web: http://192.168.64.20:0
I had to use gofabric8 service vertx-web to get the external url so I can hit it from my web browser. The other quickstarts report correct port number than 0.

@davsclaus
Copy link
Contributor Author

Ah I see the same port 0 in the cdi-cxf quickstart

[INFO] F8:[SVC] cdi-cxf: http://192.168.64.20:0

@rhuss @jstrachan wonder if you guys have seen this with the new f-m-p that the service url listed dont include the correct external port number

The port can be retrieved from gofabric8

davsclaus:/Users/davsclaus/$ gofabric8 service cdi-cxf --url
http://192.168.64.20:31144

@rhuss
Copy link
Contributor

rhuss commented Nov 22, 2016

@davsclaus will check that tomorrow, thanks for reporting ;-)

@rhuss
Copy link
Contributor

rhuss commented Dec 2, 2016

sorry, for the delay, its not forgotten. will tackle that hopefully today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants