-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new vertx generator for f-m-p #55
Comments
@kameshsampath maybe you want to take a look and do a PR to update this sample to use your new plugin |
@davsclaus we just need to make the first release to Maven central ;-) (which we will do today) |
will check this out later today @davsclaus and do the required update |
@davsclaus i have updated the project with v-m-p, but enroute found an fabric8io/vertx-maven-plugin#15, will send a PR once we do the next release of the v-m-p |
@davsclaus and @rhuss - fixed this via #57 , please review and merge. Tested locally via k8s and using plugin both works |
Thanks just ran it locally and it works, however not sure why SVC shows the port as 0 and not the actual external port [INFO] F8:[SVC] vertx-web: http://192.168.64.20:0 |
Ah I see the same port 0 in the cdi-cxf quickstart
@rhuss @jstrachan wonder if you guys have seen this with the new f-m-p that the service url listed dont include the correct external port number The port can be retrieved from gofabric8
|
@davsclaus will check that tomorrow, thanks for reporting ;-) |
sorry, for the delay, its not forgotten. will tackle that hopefully today. |
We can simpify the pom.xml to use the f-m-p plugin to build the JAR and whatnot
https://maven.fabric8.io/#generator-vertx
The text was updated successfully, but these errors were encountered: