Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Persist users who login using api_client param #673

Open
sbose78 opened this issue Oct 1, 2018 · 5 comments
Open

Persist users who login using api_client param #673

sbose78 opened this issue Oct 1, 2018 · 5 comments
Milestone

Comments

@sbose78
Copy link
Member

sbose78 commented Oct 1, 2018

  1. On login, check if api_client param is present ( as done now ). If the user doesn't exist in the DB, create a record before returning a token.

  2. [ not critical now ] Modify Create User API to allow updating the user record with the cluster api url. This change would be needed if the same RHD user now wishes to login to OSiO.

@sbose78
Copy link
Member Author

sbose78 commented Oct 1, 2018

We could do (1) now and move on. If needed, we could add support for (2) later on.

@sbose78
Copy link
Member Author

sbose78 commented Oct 1, 2018

@sbryzak This should solve the concern of issuing tokens to users whose record doesn't exist. What do you think?

@sbryzak
Copy link
Member

sbryzak commented Oct 1, 2018

@sbose78 Certainly, this would solve the problem of unrevokable tokens, as we would be able to create a token record if the user has a corresponding identity record.

@dipak-pawar dipak-pawar self-assigned this Oct 1, 2018
@xcoulon xcoulon added this to the Sprint 155-3 milestone Oct 1, 2018
@xcoulon
Copy link
Contributor

xcoulon commented Oct 1, 2018

@sbose78 if step 2 is not critical for now and can be addressed later, shouldn't we open a separate issue for it?

@sbose78
Copy link
Member Author

sbose78 commented Oct 1, 2018

if step 2 is not critical for now and can be addressed later, shouldn't we open a separate issue for it?

Yeah, if it's not solved in a single PR, we could do that.

@xcoulon xcoulon modified the milestones: Sprint 155, Sprint 156 Oct 3, 2018
@xcoulon xcoulon modified the milestones: Sprint 156, Sprint 157 Oct 23, 2018
@xcoulon xcoulon modified the milestones: Sprint 157, sprint 158 Nov 12, 2018
@alexeykazakov alexeykazakov modified the milestones: Sprint 158, Sprint 159 Nov 15, 2018
@xcoulon xcoulon modified the milestones: Sprint 159, Sprint 160 Jan 4, 2019
@xcoulon xcoulon modified the milestones: Sprint 160, Sprint 161 Jan 16, 2019
@xcoulon xcoulon modified the milestones: Sprint 161, Sprint 162 Feb 7, 2019
@alexeykazakov alexeykazakov assigned sbryzak and unassigned dipak-pawar and sbryzak Feb 8, 2019
@xcoulon xcoulon modified the milestones: Sprint 162, Sprint 163 Feb 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants