This repository was archived by the owner on May 6, 2021. It is now read-only.

Investigate if "apisever" is a typo or relying on a bug #249

Closed

sthaha opened this issue Jun 4, 2018 · 4 comments

Labels

kind/bug priority/major

Contributor

sthaha commented Jun 4, 2018 •

edited

Loading

I find "apiserver" being referred to as apisever in two places

https://github.com/sthaha/fabric8-jenkins-idler/blob/74726f37c108209cf60cbb416ffc2e341916087e/internal/openshift/client/openshift_client.go#L267
https://github.com/sthaha/fabric8-jenkins-idler/blob/74726f37c108209cf60cbb416ffc2e341916087e/internal/openshift/client/openshift_client.go#L329

Is this a typo or relying on an openshift bug ? Whatever may the case be lets fix it or document it.

The text was updated successfully, but these errors were encountered:

sthaha added kind/bug priority/major labels

Contributor

chmouel commented Jun 4, 2018

it's a string and i would imagine that code was copied and paste, i think it's safe to sed it,

Contributor Author

sthaha commented Jun 4, 2018

kubernetes/kubernetes@b930835#diff-4d193a406d7afdfbe52668d8c53f522e seems to have fixed the bug upstream recently (5 months back)

Contributor Author

sthaha commented Jun 4, 2018

@chmouel no, it was relying on the bug indeed :)

Member

hrishin commented Dec 21, 2018

closing this issue as its addressed by #301

hrishin closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.