Skip to content
This repository has been archived by the owner on May 6, 2021. It is now read-only.

Handle large tenant update gracefully #324

Closed
chmouel opened this issue Jan 8, 2019 · 8 comments
Closed

Handle large tenant update gracefully #324

chmouel opened this issue Jan 8, 2019 · 8 comments

Comments

@chmouel
Copy link
Contributor

chmouel commented Jan 8, 2019

This is a follow up on the discussion happenning here :

https://chat.openshift.io/developers/pl/reegarnowty9iedkyqujgfcm1o

When there is a large tenant update all pods gets awaken, we need to be able to
handle this gracefully.

A workflow like this, tenant update (for jenkins pod) start :

  • Disable idler for the tenant that is about to be updated via a REST api call to idler,
  • Unidle this user (via oc command or a REST api call)
  • Do the tenant update.
  • Idle the pods
  • Renable idler for this user via a REST api

I am not sure if it would help that much the load but at least the flow will be
more controlled, it sure would be better than guessing what's happening on the events received to idler.

Feel free to update this issue if you think of a better/improved solution,

@chmouel
Copy link
Contributor Author

chmouel commented Jan 8, 2019

@pbergene
Copy link

pbergene commented Jan 8, 2019

Idler needs to be running as a full cluster can't handle necessarily handle all pods awake at the same time. This has usually been handled by adding a delay to the tenant update, to ensure idling kicks in before the cluster becomes overloaded.

@chmouel
Copy link
Contributor Author

chmouel commented Jan 8, 2019

@pbergene yep, just to clarify, it's only disabling idler operation for the user/tenant that is going to be updated, not the whole idler, (updated the issue)

@pbergene
Copy link

pbergene commented Jan 8, 2019

@chmouel Ah. Good :) I'll read next time

@chmouel
Copy link
Contributor Author

chmouel commented Jan 8, 2019

This probaby is related: #232 and #83

But it would be good to keep this issue to discuss the strategy of how to handle large tenant update, just not disabling idler for a user

@hrishin
Copy link
Member

hrishin commented Jan 13, 2019

Yes, it also related to #301 issue.

@chmouel chmouel closed this as completed May 4, 2019
@hrishin
Copy link
Member

hrishin commented May 6, 2019

@chmouel you closed it intentionally?
just wanted to confirm

@chmouel
Copy link
Contributor Author

chmouel commented May 6, 2019

I closed most of my old created issues, we are not working on idler anymore so may as well,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants