Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): Lifecycle listeners should throw a warning if the lifecycle event will not exist #14

Open
scott-wyatt opened this issue Aug 7, 2018 · 4 comments
Labels
bug Something isn't working enhancement New feature or request Hacktoberfest

Comments

@scott-wyatt
Copy link
Contributor

Issue Description

Lifecycle listeners should throw a warning if the lifecycle event will not exist.

Environment

  • node version: 10.0.0
  • fabrix version: > 1.1.4
  • operating system: macOS, Linux
@scott-wyatt scott-wyatt added bug Something isn't working enhancement New feature or request labels Aug 7, 2018
@scott-wyatt
Copy link
Contributor Author

Maybe this will be the year! #hacktoberfest

@scott-wyatt scott-wyatt changed the title [chore] Lifecycle listeners should throw a warning if the lifecycle event will not exist chore(): Lifecycle listeners should throw a warning if the lifecycle event will not exist Oct 14, 2019
@jaumard
Copy link
Member

jaumard commented Oct 23, 2019

Not sure there is enough details to be taken into an hacktoberfest ^^ even me who know a bit the subject I don't understand the issue :D

Can you explain more what's need to be done here ? maybe with a use case

@scott-wyatt
Copy link
Contributor Author

scott-wyatt commented Oct 23, 2019 via email

@jaumard
Copy link
Member

jaumard commented Oct 23, 2019

now I understand :p ha ha no worry :)

but how can we do that ? just parsing the event to retrieve sequelize and check that the spool is available under main.spools ? but we have to keep in mind that wanted event can be "or" or "and" (if I remember correctly ^^) so we need to manage that logic too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants