Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promises, Woop #24

Open
samjam48 opened this issue Dec 13, 2019 · 1 comment
Open

Promises, Woop #24

samjam48 opened this issue Dec 13, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@samjam48
Copy link

Great work on promisfying your hash functions 😎

You should clear out the old commented code to keep a clean working area.

Promisfy database
I wouldn't bother now but for next project you can implement the database, queries and tests with promises instead which makes life a bit easier with no more callbacks.
some headaches tracing through the whole process but basically there is a promise enabled sql library for each part. You can look at this example for how I got it working
https://github.com/facn6/food-diary-week-8/tree/master/src/model/database
(note tests work but there's a better implementation)

@samjam48 samjam48 added the enhancement New feature or request label Dec 13, 2019
@AlexandraOM
Copy link
Collaborator

Thanks! V useful for next project, now we have promises we're never going back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants