Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up eslint errors #48

Open
ivan-unfolds opened this issue Jan 26, 2023 · 0 comments
Open

Tidy up eslint errors #48

ivan-unfolds opened this issue Jan 26, 2023 · 0 comments

Comments

@ivan-unfolds
Copy link

I noticed you have a lot of eslint errors. It's good practice to make sure that any code merged into main doesn't have any errors, including linting ones. Usually this is automated by making a github action that runs on every PR and doesn't let developers merge the PR in unless all tests are passing, eslint is error-free etc.

Also I would recommend using eslint/recommended rather than airbnb-base as it's much less opinionated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant