Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review #42

Open
ighellache opened this issue May 24, 2023 · 0 comments
Open

Code Review #42

ighellache opened this issue May 24, 2023 · 0 comments

Comments

@ighellache
Copy link

ighellache commented May 24, 2023

What I love:
-I didn't know you can have a reset button - that's awesome
-I love the clean look of the website.
-The database and model folders are clear.
-Overall the code is readable.
-Style guide.

What I'm curious about:
-It's interesting that you haven't used a routes folder.
-The styling is in the templates file?
-When I clicked submit to add a new artist, song and url, I was redirected back to the beginning and the new data isn't updated onto the page. Perhaps this is just something you just haven't gotten round to yet.
-Have you looked into sanitize and validate?
-Readme doesn't really tell me what the app is, perhaps add an introductory paragraph to explain what it is.
-Make sure to delete your branches after merging changes from them.
-Some branch names are quite ambiguous e.g. 'merge changes'.
-Recroom makes me think of this https://recroom.com/. It's nothing bad just an observation haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant