Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taha's Issues #47

Open
Taha-Hassan-Git opened this issue Jul 26, 2023 · 0 comments
Open

Taha's Issues #47

Taha-Hassan-Git opened this issue Jul 26, 2023 · 0 comments

Comments

@Taha-Hassan-Git
Copy link

I can see that a huge amount of work has been done on the site. Getting the database up and running and the google maps api sort-of working, as well as building a carousel from scratch. It's a really impressive achievement.

I've got some questions though:

There appear to be some components that are nested along with the page.tsx file they're associated with (LogInForm.tsx), and others that appear to only be used on one page, but are in src/components. Are they intended to be used in multiple places?

We were encouraged by our mentor and product owner to avoid carousels in order to avoid accessibility issues that come from using them in the short time frame we have to develop. Have you considered some of those issues and what their solutions might be?

The search functionality looks super useful and detailed. But do you need to show all of the options at once? What about using accordions to reveal only categories the user is interested in? This might help to fit everything on mobile view.

Sorry have to go!

Wishing you the best of luck for your second sprint!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant