Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to id-tagging-schema v6 #846

Closed
bhousel opened this issue Mar 16, 2023 · 4 comments
Closed

Upgrade to id-tagging-schema v6 #846

bhousel opened this issue Mar 16, 2023 · 4 comments
Assignees

Comments

@bhousel
Copy link
Contributor

bhousel commented Mar 16, 2023

Just tracking that I updated the preset code to add partial support for the id-tagging-schema v6 that was recently released.

Some things we don't support at this time:

  • Röntgen icons (there are only a few of these anyway and they are hard to generate)
  • Preset "Aliases" (these are like terms but different)
  • New types of fields yet (like colour , date, or directionalCombo) but mappers can still add this information in the raw tag editor like they used to be able to.
  • Icons in combo field values

I'll link back to this issue if/when we add more support for these things.

Work was done in these commits

  • 0bef7fb - Resolve preset and field references new to id-tagging-schema v6
  • 53699bb - Fetch strings for id-tagging-schema v6 as well
  • df41f3d - Upgrade to id-tagging-schema v6
@bhousel bhousel closed this as completed Mar 16, 2023
@bhousel bhousel self-assigned this Mar 16, 2023
@bryceco
Copy link

bryceco commented Mar 17, 2023

The Röntgen dependency is a PITA and really ridiculous. There's no way I'm adding all those prerequisites to my project, so for now I'm just copying them from iD from https://raw.githubusercontent.com/openstreetmap/iD/develop/svg/roentgen/*

Hopefully they fix this upstream.

@tordans
Copy link

tordans commented Mar 17, 2023

FYI I created enzet/map-machine#149 to track the issues of having the icons more easily consumed. I think there was no issue, yet, and it sounds like that really should be easier.

@bhousel
Copy link
Contributor Author

bhousel commented Mar 17, 2023

Yes, I know I could copy the icons from the iD repo, but I really don't want the increased maintenance burden of looking there for new icons. For now these are the replacements I hardcoded:

https://github.com/facebook/RapiD/blob/0bef7fbea4a120201135335d39b7196564c8889f/modules/presets/index.js#L25-L37

bhousel added a commit that referenced this issue May 1, 2023
(re: #846)

The work I just did on #925 gives us much more flexibility to support new
spritesheets.  These get converted to WebGL textures on the fly now, so we
don't need to prepare a special spritesheet anymore.
@bhousel
Copy link
Contributor Author

bhousel commented May 1, 2023

I just added the Röntgen icons in 589d43d .

The work I just completed on #925 gives us much more flexibility to support new spritesheets. These get converted to WebGL textures on the fly now, so we don't need to prepare a separate spritesheet for Pixi anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants