Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement mockable in-memory database #332

Open
afterdusk opened this issue Jan 3, 2023 · 1 comment
Open

Implement mockable in-memory database #332

afterdusk opened this issue Jan 3, 2023 · 1 comment

Comments

@afterdusk
Copy link
Member

This would be helpful in tests to assert expected database access patterns. For example, if unexpected reads or writes are performed. See:
@afterdusk afterdusk mentioned this issue Jan 3, 2023
Merged
slawlor added a commit to slawlor/akd that referenced this issue Jan 3, 2023
@slawlor
Adding mock support for the Database trait in AKD
1e0d5d9 
Related to: facebook#332
@slawlor slawlor mentioned this issue Jan 3, 2023
Merged
slawlor added a commit to slawlor/akd that referenced this issue Jan 4, 2023
@slawlor
Adding mock support for the Database trait in AKD
d566324 
Related to: facebook#332
slawlor added a commit that referenced this issue Jan 4, 2023
@slawlor
Adding mock support for the Database trait in AKD (#333)
7bb93b7 
* Adding mock support for the Database trait in AKD

Related to: #332

* adding a mocked database test

* Move to Arc in StorageManager so we can clone it cleanly.

* Make storage manager create and manage the Arc

* Bump version for contract changes
@slawlor
Copy link
Contributor

slawlor commented Jan 12, 2023

@afterdusk I think we now support the mocks, but I guess do we want to leave this task open to implement the test adjustments we want now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slawlor @afterdusk