From 7807ce2de8fed794e75039b56da4ac2a605352be Mon Sep 17 00:00:00 2001
From: Sergey Tyurin <tyurins@fb.com>
Date: Mon, 17 Jun 2019 10:23:52 -0700
Subject: [PATCH] Add visibility to configuration targets in tests

Summary: This will be enforced later.

Reviewed By: jtorkkola

shipit-source-id: de08c23f5e
---
 .../project_with_constraints/BUCK.fixture     | 30 +++++++++++++++++++
 .../testdata/simple_project/BUCK.fixture      | 18 +++++++++++
 .../testlibs/config/constraints/BUCK          | 27 +++++++++++++++++
 3 files changed, 75 insertions(+)

diff --git a/test/com/facebook/buck/core/rules/configsetting/testdata/project_with_constraints/BUCK.fixture b/test/com/facebook/buck/core/rules/configsetting/testdata/project_with_constraints/BUCK.fixture
index 46aa0d14a8e..410ee49ea88 100644
--- a/test/com/facebook/buck/core/rules/configsetting/testdata/project_with_constraints/BUCK.fixture
+++ b/test/com/facebook/buck/core/rules/configsetting/testdata/project_with_constraints/BUCK.fixture
@@ -4,6 +4,9 @@ platform(
         "buck//config/constraints:osx",
         "buck//config/constraints:x86_64",
     ],
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 platform(
@@ -12,6 +15,9 @@ platform(
         "buck//config/constraints:linux",
         "buck//config/constraints:aarch64",
     ],
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 platform(
@@ -20,6 +26,9 @@ platform(
         "buck//config/constraints:arm",
         "buck//config/constraints:linux",
     ],
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 config_setting(
@@ -27,6 +36,9 @@ config_setting(
     constraint_values = [
         "buck//config/constraints:osx",
     ],
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 config_setting(
@@ -35,6 +47,9 @@ config_setting(
         "buck//config/constraints:osx",
         "buck//config/constraints:x86_64",
     ],
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 config_setting(
@@ -46,6 +61,9 @@ config_setting(
     values = {
         "cat.file": "a",
     },
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 config_setting(
@@ -58,6 +76,9 @@ config_setting(
         "cat.file": "a",
         "cat.file2": "b",
     },
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 config_setting(
@@ -66,6 +87,9 @@ config_setting(
         "buck//config/constraints:linux",
         "buck//config/constraints:aarch64",
     ],
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 config_setting(
@@ -76,6 +100,9 @@ config_setting(
     values = {
         "cat.file": "a",
     },
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 config_setting(
@@ -87,6 +114,9 @@ config_setting(
     values = {
         "cat.file": "b",
     },
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 genrule(
diff --git a/test/com/facebook/buck/core/rules/configsetting/testdata/simple_project/BUCK.fixture b/test/com/facebook/buck/core/rules/configsetting/testdata/simple_project/BUCK.fixture
index b89702a8fab..8923794c348 100644
--- a/test/com/facebook/buck/core/rules/configsetting/testdata/simple_project/BUCK.fixture
+++ b/test/com/facebook/buck/core/rules/configsetting/testdata/simple_project/BUCK.fixture
@@ -34,6 +34,9 @@ config_setting(
     values = {
         "cat.file": "a",
     },
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 config_setting(
@@ -41,6 +44,9 @@ config_setting(
     values = {
         "cat.file": "b",
     },
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 config_setting(
@@ -49,6 +55,9 @@ config_setting(
         "cat.file": "b",
         "cat.file2": "c",
     },
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 genrule(
@@ -70,6 +79,9 @@ config_setting(
     values = {
         "another.option": "c",
     },
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 genrule(
@@ -95,6 +107,9 @@ config_setting(
     values = {
         "java.version": "7",
     },
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 config_setting(
@@ -102,6 +117,9 @@ config_setting(
     values = {
         "java.version": "8",
     },
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 java_library(
diff --git a/test/com/facebook/buck/testutil/integration/testlibs/config/constraints/BUCK b/test/com/facebook/buck/testutil/integration/testlibs/config/constraints/BUCK
index fa6afe9e5e2..d5004b2328f 100644
--- a/test/com/facebook/buck/testutil/integration/testlibs/config/constraints/BUCK
+++ b/test/com/facebook/buck/testutil/integration/testlibs/config/constraints/BUCK
@@ -1,42 +1,69 @@
 os_constraint_detector(
     name = "os-detector",
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 constraint_setting(
     name = "os",
     host_constraint_detector = ":os-detector",
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 constraint_value(
     name = "linux",
     constraint_setting = ":os",
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 constraint_value(
     name = "osx",
     constraint_setting = ":os",
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 cpu_constraint_detector(
     name = "cpu-detector",
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 constraint_setting(
     name = "cpu",
     host_constraint_detector = ":cpu-detector",
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 constraint_value(
     name = "x86_64",
     constraint_setting = ":cpu",
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 constraint_value(
     name = "aarch64",
     constraint_setting = ":cpu",
+    visibility = [
+        "PUBLIC",
+    ],
 )
 
 constraint_value(
     name = "arm",
     constraint_setting = ":cpu",
+    visibility = [
+        "PUBLIC",
+    ],
 )