Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codemod internal library methods in fb_fstab to make it clear they're not part of the API #162

Open
davide125 opened this issue Jan 25, 2021 · 0 comments

Comments

@davide125
Copy link
Member

Stuff like FB::Fstab.get_unmasked_base_mounts isn't safe to call from random cookbooks as it relies on node data that may not necessarily be there or be correct. Audit all methods, codemod the internal ones with a _ and document the rest properly in README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant