Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for node 16 (current release) and scss #11037

Open
Bajdzis opened this issue May 31, 2021 · 5 comments
Open

Add support for node 16 (current release) and scss #11037

Bajdzis opened this issue May 31, 2021 · 5 comments

Comments

@Bajdzis
Copy link

Bajdzis commented May 31, 2021

Is your proposal related to a problem?

I start using node 16. My dependency node-scss require update to 6 version. When update this dependency and try build my app i have error:

Node Sass version 6.0.0 is incompatible with ^4.0.0 || ^5.0.0.

Describe the solution you'd like

We must update sass-loader to 10.2.0 version :)
https://github.com/webpack-contrib/sass-loader/releases

Describe alternatives you've considered

Try configure SCSS in CRA without node-scss because this package is deprecated :

Warning: LibSass and Node Sass are deprecated. While they will continue to receive maintenance releases indefinitely, there are no plans to add additional features or compatibility with any new CSS or Sass features. Projects that still use it should move onto Dart Sass.

https://www.npmjs.com/package/node-sass

@daniel-flex
Copy link

+1. Am stuck in a pickle with CRA as I can't compile a sass/scss file.

@textbook
Copy link

textbook commented Jun 4, 2021

Note that Node 16 isn't yet the Active LTS release, it's Node 14 until the end of October per e.g. https://nodejs.org/en/about/releases/.

@Bajdzis Bajdzis changed the title Add support for node 16 (current LTS) and scss Add support for node 16 (current release) and scss Jun 6, 2021
@maxburke
Copy link

Any updates to this issue?

Node 14 isn't really an option for people using Apple Silicon computers; only node 15 or 16 are supported.

@BenJenkinson
Copy link

Since react-scripts 4.0.2, you may use sass instead of node-sass to use SCSS stylesheets within your create-react-app app.

The documentation hasn't yet been updated to match, but the instructions are the same. Just replace node-sass with sass:

$ npm install sass --save

@quiram
Copy link

quiram commented Sep 9, 2021

We must update sass-loader to 10.2.0 version :)

Did this work for anyone else? as far as I can tell [email protected] requires fibers, which is incompatible with node 16 (and looks like will never be compatible). See laverdet/node-fibers#451

0p3r4t0r added a commit to 0p3r4t0r/japanese-typing-practice that referenced this issue Oct 31, 2021
kas-catholic added a commit to kas-catholic/confessit-web that referenced this issue Nov 21, 2021
Node 16 is the current LTS release and has support for M1 macs.
Fortunately most of our JS is very common/simple, so the upgrade should
be painless.

Making this upgrade also required replacing node-sass with sass:
facebook/create-react-app#11037
Ex. vitessio/vitess#9136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants