Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default log files are created even if different paths are provided via options #720

Open
slabstone opened this issue Aug 9, 2023 · 0 comments

Comments

@slabstone
Copy link

Default log dir and files log/access.log and log/error.log are created even if different paths are provided via --access-log and --error-log options, leading to permission concerns.

duckling: log/error.log: openFile: permission denied (Permission denied)

This relates to #377, where logfile creation was disabled in case of --no-access-log and --no-error-log.

Reproducable on 7520daa:

$ ls
duckling-example-exe

$ ./duckling-example-exe --access-log=./a.log --error-log=./e.log
no port specified, defaulting to port 8000
Listening on http://0.0.0.0:8000
^C
Shutting down..

$ ls -R
.:
a.log  duckling-example-exe  e.log  log

./log:
access.log  error.log

Here both default and user-provided files are created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant