Skip to content

Commit b79d697

Browse files
author
Paul Groudas
committed
Fix Makefile
I am unsure as to why, but the dependency expressed as "mcrouter: deps" doesn't seem to work correctly. When invoking the equivalent of "make mcrouter", I expect it to build all the transitive dependencies of "deps", but it only builds the first dependency that it determines it needs to build, and then exits with a return value of "2". I'm just reverting this to the previous style that is redundant but works correctly.
1 parent c798225 commit b79d697

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

mcrouter/scripts/Makefile_amazon-linux-2

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ all: mcrouter
5353
deps: .fbthrift-done .folly-done .fizz-done .wangle-done .fmt-done .zstd-done .glog-done .gflags-done .boost-done
5454
touch $@
5555

56-
mcrouter: deps
56+
mcrouter: .fbthrift-done .folly-done .fizz-done .wangle-done .fmt-done .zstd-done .glog-done .gflags-done .boost-done
5757
${RECIPES_DIR}/mcrouter.sh $(PKG_DIR) $(INSTALL_DIR) $(INSTALL_AUX_DIR)
5858
touch $@
5959

0 commit comments

Comments
 (0)