Skip to content

Commit

Permalink
Fix Makefile
Browse files Browse the repository at this point in the history
I am unsure as to why, but the dependency expressed as "mcrouter: deps"
doesn't seem to work correctly.

When invoking the equivalent of "make mcrouter", I expect it to build
all the transitive dependencies of "deps", but it only builds the first
dependency that it determines it needs to build, and then exits with
a return value of "2".

I'm just reverting this to the previous style that is redundant but
works correctly.
  • Loading branch information
Paul Groudas committed May 3, 2021
1 parent c798225 commit b79d697
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mcrouter/scripts/Makefile_amazon-linux-2
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ all: mcrouter
deps: .fbthrift-done .folly-done .fizz-done .wangle-done .fmt-done .zstd-done .glog-done .gflags-done .boost-done
touch $@

mcrouter: deps
mcrouter: .fbthrift-done .folly-done .fizz-done .wangle-done .fmt-done .zstd-done .glog-done .gflags-done .boost-done
${RECIPES_DIR}/mcrouter.sh $(PKG_DIR) $(INSTALL_DIR) $(INSTALL_AUX_DIR)
touch $@

Expand Down

0 comments on commit b79d697

Please sign in to comment.